Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for multiple sinks, multiple triggers #7350

Conversation

Cali0707
Copy link
Member

Fixes #7241

Proposed Changes

  • Add a test with multiple triggers and multiple sinks

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Oct 11, 2023
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2023
@Cali0707
Copy link
Member Author

/cc @creydr @matzew @pierDipi

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a0e4c18) 76.86% compared to head (89dcbe7) 76.86%.
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7350   +/-   ##
=======================================
  Coverage   76.86%   76.86%           
=======================================
  Files         252      252           
  Lines       13727    13727           
=======================================
  Hits        10551    10551           
  Misses       2650     2650           
  Partials      526      526           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cali0707
Copy link
Member Author

/cc @Leo6Leo

@knative-prow knative-prow bot requested a review from Leo6Leo October 12, 2023 17:24
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 4d14c21 into knative:main Oct 19, 2023
34 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Event Filtering: Add rekt test for multiple triggers & sinks
2 participants