Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] Autoscaler considers reserved and pending replicas #7216

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #7027

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot requested review from lberk and pierDipi August 31, 2023 15:45
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 51.12% and project coverage change: -0.22% ⚠️

Comparison is base (3ccfc1c) 77.95% compared to head (8715eb9) 77.74%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.11    #7216      +/-   ##
================================================
- Coverage         77.95%   77.74%   -0.22%     
================================================
  Files               250      250              
  Lines             13419    13506      +87     
================================================
+ Hits              10461    10500      +39     
- Misses             2422     2470      +48     
  Partials            536      536              
Files Changed Coverage Δ
pkg/scheduler/statefulset/scheduler.go 72.43% <10.81%> (-4.84%) ⬇️
pkg/scheduler/state/state.go 82.31% <65.71%> (-2.22%) ⬇️
pkg/scheduler/statefulset/autoscaler.go 76.99% <67.21%> (-0.66%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
@pierDipi
Copy link
Member

pierDipi commented Sep 1, 2023

/test upgrade-tests

@knative-prow knative-prow bot merged commit cf0f9d5 into knative:release-1.11 Sep 1, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants