Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: knadh/koanf
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.3.0
Choose a base ref
...
head repository: knadh/koanf
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.3.1
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Nov 1, 2021

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    14b8037 View commit details

Commits on Nov 2, 2021

  1. Merge pull request #116 from rhnvrm/fix-s3-err

    fix: incorrect warning log in case of s3 file-dl
    knadh authored Nov 2, 2021
    Copy the full SHA
    a448a38 View commit details
Showing with 2 additions and 6 deletions.
  1. +2 −6 providers/s3/s3.go
8 changes: 2 additions & 6 deletions providers/s3/s3.go
Original file line number Diff line number Diff line change
@@ -5,7 +5,6 @@ package s3
import (
"errors"
"io/ioutil"
"log"

"github.com/rhnvrm/simples3"
)
@@ -51,20 +50,17 @@ func (r *S3) ReadBytes() ([]byte, error) {
Bucket: r.cfg.Bucket,
ObjectKey: r.cfg.ObjectKey,
})

if err != nil {
data, _ := ioutil.ReadAll(resp)
log.Println(string(data))
return nil, err
}

defer resp.Close()

data, err := ioutil.ReadAll(resp)
if err != nil {
return nil, err
}

resp.Close()

return data, nil
}