We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
caver.utils.isBN returns 'true' but it should have to return 'false'
const notBn = {} notBn.constructor = {} notBn.constructor.name = 'BN' console.log(caver.utils.isBN(test))
How to reproduce same with above
Expected behavior caver.utils.isBN should work as like as BN.js works
Attachments web3.js already covered that
Environment (please complete the following information)
Additional context NA
The text was updated successfully, but these errors were encountered:
Hi :)
Is this issue related with web3/web3.js#1777? I will apply this modification to caver-js. And also i will add test case what you describe above.
Thank you for reporting this issue !
Sorry, something went wrong.
@skqksh Hi, PR is uploaded :) #207
If there is any opinion about this change, please feel free to comments on PR.
jimni1222
Successfully merging a pull request may close this issue.
Describe the bug
caver.utils.isBN returns 'true' but it should have to return 'false'
How to reproduce
same with above
Expected behavior
caver.utils.isBN should work as like as BN.js works
Attachments
web3.js already covered that
Environment (please complete the following information)
Additional context
NA
The text was updated successfully, but these errors were encountered: