Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate golang/go#11030 #2

Closed
toqueteos opened this issue Jul 28, 2015 · 5 comments
Closed

Integrate golang/go#11030 #2

toqueteos opened this issue Jul 28, 2015 · 5 comments

Comments

@toqueteos
Copy link

Hi there,

I just found your project, also skimmed over pgzip. Is zlib support somewhat planned or it's just not worth it? After checking zlib's source code it's just 150 lines of extensive use of compress/flate and hash/adler32.

p.d: Thanks for your work! Having golang/go#11030 resolved in an external library compatible with 1.4 is awesome!
@klauspost
Copy link
Owner

I added zlib. Thanks for the suggestion.

I based the code on 1.4.2, so I actually don't think the patch above is included. However, it seems like it would be trivial to do so.

@klauspost
Copy link
Owner

(changing the title)

@klauspost klauspost changed the title Question: no compress/zlib support? Integrate golang/go#11030 Jul 28, 2015
@klauspost klauspost mentioned this issue Jul 28, 2015
Merged
@klauspost
Copy link
Owner

Merged, all tests pass.

@toqueteos
Copy link
Author

Woah, that was amazingly fast! Thank you very much!

@klauspost
Copy link
Owner

Yes, it was mostly changes to Inflate, which I haven't touched.

klauspost pushed a commit that referenced this issue Oct 11, 2023
@viktoriia-lsg
Fuzzing Coverage Expansion (#2) (#870)
4af4344 
* test: update dict_test.go for oss-fuzz

The content of testdata/s2-dict.bin.gz file was embedded to fuzz target FuzzDictBlocks.

* Update dict_test.go

Take gzip content and place into base64 to avoid encoding issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toqueteos @klauspost