Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue found in/using golangci-lint, about warnings not processing properly #21

Closed
mrz1836 opened this issue Mar 20, 2024 · 2 comments · Fixed by #22
Closed

Issue found in/using golangci-lint, about warnings not processing properly #21

mrz1836 opened this issue Mar 20, 2024 · 2 comments · Fixed by #22

Comments

@mrz1836
Copy link

mrz1836 commented Mar 20, 2024

Please see this issue:

golangci/golangci-lint#4550

We have concluded it's an issue in contextcheck but I do not know specifically what is going on. There is example code and changes made that can reproduce the issue:

golangci/golangci-lint#4550 (comment)
@kkHAIKE
Copy link
Owner

kkHAIKE commented Mar 20, 2024

it's fix: golangci/golangci-lint#4552

@kkHAIKE kkHAIKE closed this as completed Mar 20, 2024
@ldez
Copy link
Contributor

ldez commented Mar 20, 2024 •
edited

@kkHAIKE It's a contextcheck bug, I just provided a workaround.

contextcheck should not report issues without a filepath.

$ ./contextcheck ./...
-: Function `NewWriteLock$1` should pass the context parameter

@ldez ldez mentioned this issue Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't report issue related to invalid position ldez/contextcheck
3 participants
@kkHAIKE @mrz1836 @ldez