Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_credentials(write=True) fails when credential only has the write permission. #11

Closed
FledgeXu opened this issue Aug 24, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@FledgeXu
Copy link

FledgeXu commented Aug 24, 2023

As I mentioned earlier, When credential only has the write permission, the check_credentials(write=True) will fail.

Repeat code:

from kiwixstorage import KiwixStorage
# This key only has write permission
a = KiwixStorage("YOUR KEY")
a.check_credentials(write=True)

The reasons is we accidentally call the delete_obejct in test_access_write

finally:
self.client.delete_object(Bucket=self.bucket_name, Key=key)

@rgaudin rgaudin added the enhancement New feature or request label Aug 24, 2023
@rgaudin
Copy link
Member

rgaudin commented Aug 24, 2023

Thanks

@rgaudin
Copy link
Member

rgaudin commented May 7, 2024

check_credentials will also raise exceptions on malformed URL. This should be captured and logged.

@rgaudin rgaudin closed this as completed in 7180b44 May 8, 2024
rgaudin added a commit that referenced this issue May 8, 2024

Verified

This commit was signed with the committer’s verified signature. The key has expired.
rgaudin rgaudin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants