Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIL text provider: Do not render text if font size is < 1 #8540

Merged
merged 2 commits into from Dec 30, 2023
Merged

PIL text provider: Do not render text if font size is < 1 #8540

merged 2 commits into from Dec 30, 2023

Conversation

DexerBR
Copy link
Contributor

@DexerBR DexerBR commented Dec 29, 2023 •
edited by misl6

Resolves #8538

PIL does not support, nor does it handle attempts to render text with font size values less than 1, resulting in various errors being raised.

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@DexerBR DexerBR mentioned this pull request Dec 29, 2023
Closed
@misl6 misl6 added this to the 2.3.0 milestone Dec 30, 2023
misl6
misl6 approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

(Will release 2.3.0rc3 on Monday)

@misl6 misl6 merged commit 1d8fdc3 into kivy:master Dec 30, 2023
36 checks passed
@DexerBR DexerBR deleted the pil-text-provider-font-size branch December 30, 2023 16:42
@DexerBR
Copy link
Contributor Author

DexerBR commented Dec 30, 2023

LGTM. Thank you!

(Will release 2.3.0rc3 on Monday)

Thank you @misl6 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misl6 misl6 misl6 approved these changes

Assignees
No one assigned
Labels
Component: core-providers kivy/core
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

PIL text provider: Critical issues if font_size is < 1
2 participants
@DexerBR @misl6