Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the NodeCode struct to expose number of backticks from inline code spans #192

Merged
merged 1 commit into from Jul 15, 2021

Conversation

vojtechkral
Copy link
Contributor

@vojtechkral vojtechkral commented Jul 14, 2021

I would like to use the information how many backtics are used for a code span,
ie. being able to tell whether `foo` or ``foo`` was used.
This adds the code to expose that information in the API.

I'm not too happy about it being a breaking change, but didn't see how it could be done otherwise.
Let me know if this is acceptable at all...

Edit: Test included.

Thanks for a nice md parser 🙂

@kivikakk kivikakk merged commit 7b1f19f into kivikakk:main Jul 15, 2021
@kivikakk
Copy link
Owner

@vojtechkral This is excellent -- thank you so much!

It is breaking, but that can't be helped with the API designed currently as it is. That's why we're in 0.x :)

Would you like a release for this, or are you happy to track main for now?

@vojtechkral
Copy link
Contributor Author

Thanks for the quick review :)
No need for a release as far as I'm concerned, tracking git's perfectly fine until there's enough reasons for a new release...

@vojtechkral
Copy link
Contributor Author

Actually, looks like I can't push my project to crates.io with a git dependency. Didn't know that was forbidden. So, if you feel like making a release in some near future that would help me. (But not a huge problem if inconvenient.)

@kivikakk
Copy link
Owner

Ahh, how frustrating. I have made it happen → 0.11.0.

@vojtechkral
Copy link
Contributor Author

Brilliant, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants