Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest-api-client): Support graph settings API #763

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

zaki-yama
Copy link
Contributor

@zaki-yama zaki-yama commented Mar 17, 2021

Why

Graph Settings API was released in 2021 Feb update!
https://kintone.cybozu.co.jp/update/main/2021-02.html#point6

What

Support the API in @kintone/rest-api-client.

How to test

See #735 and #731 .

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed yarn lint and yarn test on the root directory.

Sorry, something went wrong.

tasshi-me and others added 2 commits March 17, 2021 09:42

Verified

This commit was signed with the committer’s verified signature.
vladfrangu Vlad Frangu
* feat(rest-api-client): implements `app.getReports`

* chore(examples/rest-api-client-demo): add demo script for `app.getReports`

* docs(rest-api-client): add documentation of `app.getReports`

* fix(rest-api-client): rename test getAppReport -> getReport

Co-authored-by: Shingo Yamazaki <shingoyamazaki00@gmail.com>

* fix(rest-api-client): fix type definition

Co-authored-by: Shingo Yamazaki <shingoyamazaki00@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* feat(rest-api-client): implement to update setting for reports

* test(rest-api-client): add test for updateReports

* chore(kintone-api-client-demo): add an example script for updateReports

* docs(rest-api-client): write a documentation updateReport

* refactor: type of report

* fix(rest-api-client): response type of updateReports

* fix(rest-api-client): attach strict type for updateReports

* test(rest-api-client): dayOfMonth is const

Co-authored-by: Shingo Yamazaki <shingoyamazaki00@gmail.com>
@github-actions github-actions bot added the pkg: rest-api-client @kintone/rest-api-client label Mar 23, 2021
@zaki-yama zaki-yama changed the title feat(rest-api-client): Support Graph Settings API feat(rest-api-client): Support graph settings API Mar 23, 2021
@zaki-yama zaki-yama marked this pull request as ready for review March 23, 2021 06:30
@zaki-yama zaki-yama requested review from a team, koba04 and chick-p and removed request for a team March 23, 2021 06:30
@zaki-yama zaki-yama added the feature New feature label Mar 23, 2021
@tasshi-me tasshi-me merged commit 32d691f into master Mar 23, 2021
@tasshi-me tasshi-me deleted the feat/graph-settings-api branch March 23, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants