Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rest-api-client): remove unnecessary props from Notification APIs #750

Merged
merged 3 commits into from
Mar 12, 2021
Merged

fix(rest-api-client): remove unnecessary props from Notification APIs #750

merged 3 commits into from
Mar 12, 2021
+0 −5

Conversation

shinsenman
Copy link
Contributor

Why

Fixes #728

What

  • removes prop notifications[].notifyToCommenter from updateGeneralNotifications
  • fixes tests updateAppUpdateGeneralNotifications and updatePerRecordNotifications (AppClient.test.ts)
  • fixes demo script updateGeneralNotifications

How to test

% yarn build
% yarn test
% yarn lint

# run demo script
% cd examples/rest-api-client-demo
% yarn run-script app updateGeneralNotifications

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed yarn lint and yarn test on the root directory.

Sorry, something went wrong.

@shinsenman
fix(rest-api-client): fix type difinition (remove notifyToCommenter)
bf67e7b
@shinsenman
fix(rest-api-client): fix test

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a0c5cf4
@shinsenman
chore(example/rest-api-client-demo): fix demo script `updateGeneralNo…
e46fc6d 
…tifications`
@shinsenman shinsenman requested review from a team, koba04 and shisama and removed request for a team March 10, 2021 16:16
@tasshi-me tasshi-me added the pkg: rest-api-client @kintone/rest-api-client label Mar 11, 2021
koba04
koba04 approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shinsenman Thank you for your first contribution!!! 🎉🎉 Great work!! 👍 👍

@koba04 koba04 merged commit 8b07e24 into kintone:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba04 koba04

@shisama shisama

Assignees
No one assigned
Labels
pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[rest-api-client] unnecessary property in the parameter of app.updateGeneralNotifications
3 participants
@shinsenman @koba04 @tasshi-me