fix(rest-api-client): prevent infinite loop when condition
contains OR clause
#726
+5
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #716 .
What
Enclose
condition
parameter ofgetAllRecords()
andgetAllRecordsWithId()
with parenthesis (()
). (See e634fb4)NOTE: I didn't enclose the
conditionit
parameter ofgetAllRecordsWithOffset()
.How to test
getAllRecords()
withcondition
parameter that meets the following conditions:condition
containsor
clause (e.g.'Customer != "foo" or Status in ("Completed")'
)You can test it easily using
getAllRecords()
demo script with modifiedcondition
parameter.Checklist
yarn lint
andyarn test
on the root directory.