[ssradapterrename] Rename ssr to renderState #2305
Merged
+41
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aff8a35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (7d58687) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2305"Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2305 |
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-lujmmpodiu.chromatic.com/ Chromatic results:
|
|
Size Change: +1 B (0%) Total Size: 96.1 kB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## initialfallback #2305 +/- ##
===================================================
- Coverage 95.14% 94.67% -0.48%
===================================================
Files 254 254
Lines 30533 30537 +4
Branches 1865 2456 +591
===================================================
- Hits 29052 28912 -140
- Misses 1462 1603 +141
- Partials 19 22 +3
... and 31 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
somewhatabstract
force-pushed
the
ssradapterrename
branch
from
043def3 to
2cd5db3
Compare
jeresig
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This renames the
ssrtest harness adapter torenderStateto more accurately reflect its purpose.Issue: XXX-XXXX
Test plan:
yarn testyarn typecheckyarn start:storybookand check the docs referencing this look right under Wonder Blocks Testing.