feat: update dependencies #228

MichaelDeBoey · 2022-06-07T16:36:15Z

I also replaced rollup-plugin-node-builtins& rollup-plugin-node-globals with rollup-plugin-polyfill-node as that's what the @rollup team recommends & the @babel team did as well in babel/babel#11098.

BREAKING CHANGE: Use Jest v28

codecov · 2022-06-07T16:43:39Z

Codecov Report

Merging #228 (da7e917) into main (01550fe) will not change coverage.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   63.33%   63.33%           
=======================================
  Files          21       21           
  Lines         600      600           
  Branches      228      227    -1     
=======================================
  Hits          380      380           
  Misses        179      179           
  Partials       41       41

Impacted Files	Coverage Δ
src/config/jest.config.js	`92.30% <ø> (ø)`
src/config/prettierrc.js	`100.00% <ø> (ø)`
src/scripts/build/rollup.js	`0.00% <0.00%> (ø)`
src/config/rollup.config.js	`71.11% <100.00%> (-0.63%)`	⬇️
src/run-script.js	`97.87% <100.00%> (+0.04%)`	⬆️
src/utils.js	`89.56% <100.00%> (+0.09%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

MichaelDeBoey · 2022-06-07T16:48:14Z

@kentcdodds Seems like snapshots are only failing on Windows for some reason 🤔

kentcdodds · 2022-06-07T16:50:37Z

Hmmm... I'm not sure. Maybe windows is adding extra lines to the output for some reason?

MichaelDeBoey · 2022-06-07T17:05:49Z

Yeah don't know either how we could fix this tbh 🤔

src/config/prettierrc.js

MichaelDeBoey · 2022-06-21T16:17:52Z

src/config/prettierrc.js

  jsxSingleQuote: false,
  printWidth: 80,
  proseWrap: 'always',
  quoteProps: 'as-needed',
  requirePragma: false,
  semi: false,
+  singleAttributePerLine: false,


https://prettier.io/docs/en/options.html#single-attribute-per-line

MichaelDeBoey · 2022-06-29T15:12:09Z

src/config/rollup.config.js

 const omit = require('lodash.omit')
+const nodePolyfills = require('rollup-plugin-polyfill-node')


I also replaced rollup-plugin-node-builtins& rollup-plugin-node-globals with rollup-plugin-polyfill-node as that's what the @rollup team recommends & the @babel team did as well in babel/babel#11098.

nickserv · 2022-08-29T14:10:55Z

Would this be safe to merge (after resolving conflicts)? I'm running into a configuration issue for the Recorder Extension's e2e test suite because of the old Jest version, and it's blocking my next major release. Let me know if I can help with anything.

kentcdodds · 2022-08-29T14:29:53Z

Once we resolve conflicts and figure out what to do about the failing build then I'm happy to merge.

nickserv · 2022-08-30T05:01:21Z

The build seems to be failing because the new version of glob requires using POSIX paths, but we're using native paths (so Windows is not using POSIX paths). I'm trying to fix this internally, but it would technically still be a breaking change, as you'd have to use POSIX --ignore patterns on Windows.

nickserv · 2022-08-30T10:52:48Z

I think I fixed it. @MichaelDeBoey can you please review MichaelDeBoey#66 when you can? It's set to merge into this PR.

kentcdodds

Looks great! Thank you so much for spending time working on this!

kentcdodds · 2022-08-30T17:50:42Z

Uh oh. Looks like the build is actually failing so we won't get a release if I merge this 😬

kentcdodds · 2022-08-30T17:51:26Z

🤦‍♂️ just read the thread and now I understand what's going on 😅 Thanks for your work @nickmccurdy! Excited to get this merged 👍

BREAKING CHANGE: Use Jest v28

* feat: update dependencies BREAKING CHANGE: Use Jest v28 * fix: use POSIX paths with glob 8 on Windows * Fix `__dirname` usage * Implement `toPOSIX` function * Move `toPOSIX` to utils * Only use POSIX when using `glob` Co-authored-by: Michaël De Boey <info@michaeldeboey.be>

kentcdodds

Super! Thank you 👏👏

github-actions · 2022-08-30T22:14:30Z

🎉 This PR is included in version 12.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

MichaelDeBoey force-pushed the update-dependencies branch 2 times, most recently from 3b417bb to 8c47ea9 Compare June 21, 2022 16:13

MichaelDeBoey changed the title ~~chore: update dependencies~~ feat: update dependencies Jun 21, 2022

MichaelDeBoey force-pushed the update-dependencies branch from 8c47ea9 to 1d91922 Compare June 21, 2022 16:16

MichaelDeBoey commented Jun 21, 2022

View reviewed changes

MichaelDeBoey force-pushed the update-dependencies branch from 4d825de to 2af70f2 Compare June 29, 2022 15:02

MichaelDeBoey commented Jun 29, 2022

View reviewed changes

MichaelDeBoey force-pushed the update-dependencies branch 2 times, most recently from 266b81d to 588fd87 Compare June 29, 2022 16:07

MichaelDeBoey force-pushed the update-dependencies branch from 588fd87 to 4f80ef3 Compare August 30, 2022 13:22

kentcdodds previously approved these changes Aug 30, 2022

View reviewed changes

feat: update dependencies

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

6ca2f16

BREAKING CHANGE: Use Jest v28

MichaelDeBoey dismissed kentcdodds’s stale review via 6ca2f16 August 30, 2022 18:38

MichaelDeBoey force-pushed the update-dependencies branch from 4f80ef3 to 6ca2f16 Compare August 30, 2022 18:38

MichaelDeBoey requested a review from kentcdodds August 30, 2022 18:46

kentcdodds approved these changes Aug 30, 2022

View reviewed changes

kentcdodds merged commit ce96bf4 into kentcdodds:main Aug 30, 2022

github-actions bot added the released label Aug 30, 2022

MichaelDeBoey deleted the update-dependencies branch August 31, 2022 06:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update dependencies #228

feat: update dependencies #228

MichaelDeBoey commented Jun 7, 2022 •

edited

Loading

codecov bot commented Jun 7, 2022 •

edited

Loading

MichaelDeBoey commented Jun 7, 2022

kentcdodds commented Jun 7, 2022

MichaelDeBoey commented Jun 7, 2022

MichaelDeBoey Jun 21, 2022

MichaelDeBoey Jun 29, 2022

nickserv commented Aug 29, 2022

kentcdodds commented Aug 29, 2022

nickserv commented Aug 30, 2022 •

edited

Loading

nickserv commented Aug 30, 2022 •

edited

Loading

kentcdodds left a comment

kentcdodds commented Aug 30, 2022

kentcdodds commented Aug 30, 2022

kentcdodds left a comment

github-actions bot commented Aug 30, 2022

		const omit = require('lodash.omit')
		const nodePolyfills = require('rollup-plugin-polyfill-node')

feat: update dependencies #228

feat: update dependencies #228

Conversation

MichaelDeBoey commented Jun 7, 2022 • edited Loading

codecov bot commented Jun 7, 2022 • edited Loading

Codecov Report

MichaelDeBoey commented Jun 7, 2022

kentcdodds commented Jun 7, 2022

MichaelDeBoey commented Jun 7, 2022

MichaelDeBoey Jun 21, 2022

Choose a reason for hiding this comment

MichaelDeBoey Jun 29, 2022

Choose a reason for hiding this comment

nickserv commented Aug 29, 2022

kentcdodds commented Aug 29, 2022

nickserv commented Aug 30, 2022 • edited Loading

nickserv commented Aug 30, 2022 • edited Loading

kentcdodds left a comment

Choose a reason for hiding this comment

kentcdodds commented Aug 30, 2022

kentcdodds commented Aug 30, 2022

kentcdodds left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 30, 2022

MichaelDeBoey commented Jun 7, 2022 •

edited

Loading

codecov bot commented Jun 7, 2022 •

edited

Loading

nickserv commented Aug 30, 2022 •

edited

Loading

nickserv commented Aug 30, 2022 •

edited

Loading