.travis.yml

@@ -1,9 +1,11 @@
 language: node_js
 node_js:
-  - "4"
-  - "6"
-  - "8"
-  - "10"
+- '4'
+- '6'
+- '8'
+- '10'
 notifications:
   email:
     on_success: never
+  slack:
+    secure: hHI67BDSUiJQeEiJI/+XJzR/oSsjYPoylhqY10WIZWXfs4TIrdLe513Fzt9BnDNtxpHnCqkgqCb1lF8gNkkOhJKezfDwOZK6HKpNp+zfn7WqBxL0VB3rPw3JoOO9JWoELwV2LyUutbw7m4+OMO45eWgQmQM4mddUMHjyV0awa7A=

CHANGELOG.md

@@ -0,0 +1,3 @@
+## [v1.6.0] - 2018-11-15
+- GH-393, GH-394 - Remove hard limit on max iters in favor of a timeout by Nick Campbell <nicholas.j.campbell@gmail.com> in 57632b0c06c56e82f40b740b8d7986be43842735
+- GH-390 - better handling of real dates which are in the past by Nick Campbell <nicholas.j.campbell@gmail.com> in 7cbcc984aea6ec063e38829f68eb9bc0dfb1c775

README.md

@@ -108,6 +108,9 @@ Gotchas
 		granularity for all dates to seconds, but felt that it wasn't a huge problem
 		so long as you were made aware. If this becomes more of an issue, We can
 		revisit it.
+* Arrow Functions for `onTick`
+    Arrow functions get their `this` context from their parent scope. Thus, if you use them, you will not get
+    the `this` context of the cronjob. You can read a little more in this ticket [GH-40](https://github.com/kelektiv/node-cron/issues/47#issuecomment-459762775)
 
 
 API

examples/at_midnight.js

@@ -0,0 +1,9 @@
+const CronJob = require('../lib/cron.js').CronJob;
+
+console.log('Before job instantiation');
+const job = new CronJob('00 00 00 * * *', function() {
+	const d = new Date();
+	console.log('Midnight:', d);
+});
+console.log('After job instantiation');
+job.start();

lib/cron.js

@@ -143,7 +143,7 @@
 			}
 
 			if (this.realDate) {
-				const diff = moment().diff(date);
+				const diff = moment().diff(date, 's');
 				if (diff > 0) {
 					throw new Error('WARNING: Date in past. Will never be fired.');
 				}
@@ -294,9 +294,17 @@
 					Object.keys(this.hour).length !== 24
 				) {
 					origDate = moment(date);
+					var curHour = date.hours();
 					date.hours(
-						date.hours() === 23 && diff > 86400000 ? 0 : date.hours() + 1
+					        date.hours() === 23 && diff > 86400000 ? 0 : date.hours() + 1
 					);
+					/*
+					* Moment Date will not allow you to set the time to 2 AM if there is no 2 AM (on the day we change the clock)
+					* We will therefore jump to 3AM if time stayed at 1AM
+					*/
+					if(curHour === date.hours()){
+					    date.hours(date.hours() + 2);
+					}
 					date.minutes(0);
 					date.seconds(0);
 					if (date <= origDate) {