Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add npmpackagejsonlint #175

Merged
merged 4 commits into from
Apr 17, 2020
Merged

Add npmpackagejsonlint #175

merged 4 commits into from
Apr 17, 2020
+5 −0

Conversation

ntwb
Copy link
Contributor

@ntwb ntwb commented Apr 15, 2020

Fixes #174

I slotted in alphabetically in with the other linters:

  { key: 'eslintConfig', over: sortEslintConfig },
  { key: 'eslintIgnore' },
  { key: 'npmpkgjsonlint', over: sortObject },
  { key: 'remarkConfig', over: sortObject },
  { key: 'stylelint' },

@ntwb
Add npmpackagejsonlint

Verified

This commit was signed with the committer’s verified signature.
eddumelendez Eddú Meléndez Gonzales
SSH Key Fingerprint: 2gq90gS5ANw25iD9sCQjrJyMU7pPxCZntbob9YuAeE4
Verified
Learn about vigilant mode
2912ae4
fisker
fisker requested changes Apr 16, 2020
View reviewed changes
Copy link
Collaborator

@fisker fisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It need to be tested.

You might also want add your lib to this list

ntwb added 2 commits April 16, 2020 10:47
@ntwb
Update README.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
2216b06
@ntwb
test: add npmpackagejsonlint test
82a610b
@ntwb
Copy link
Contributor Author

ntwb commented Apr 16, 2020

Thanks, done 👍🏼

@fisker
Copy link
Collaborator

fisker commented Apr 16, 2020

Want sort deeper? Like eslint

fisker
fisker reviewed Apr 16, 2020
View reviewed changes
README.md Outdated
@@ -180,6 +180,7 @@ console.log(Object.keys(sorted))
- [lint-staged](https://github.com/okonet/lint-staged)
- [Mocha](https://mochajs.org/)
- [node-pre-gyp](https://github.com/mapbox/node-pre-gyp)
- [npm-package-json-lint](npmpackagejsonlint.org/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken link

keithamus
keithamus approved these changes Apr 17, 2020
View reviewed changes
Copy link
Owner

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@keithamus keithamus merged commit 6c4b1ea into keithamus:master Apr 17, 2020
@github-actions
Copy link

🎉 This PR is included in version 1.42.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ntwb ntwb deleted the patch-1 branch April 19, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisker fisker

@keithamus keithamus

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add https://www.npmjs.com/package/npm-package-json-lint
3 participants
@ntwb @fisker @keithamus