Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: order of dependencies #115

Merged
merged 1 commit into from
Jan 3, 2020
Merged

fix: order of dependencies #115

merged 1 commit into from
Jan 3, 2020
+4 −4

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Dec 31, 2019

  1. move resolutions above dependencies, I think it's more important even than dependencies
  2. move bundledDependencies under object type of dependencies
  3. test resolutions together with dependencies

@fisker
fix: order of dependencies

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
GPG key ID: 78AC5AE55A47A65B
Verified
Learn about vigilant mode
286cb07
@keithamus keithamus merged commit c01cbc7 into keithamus:master Jan 3, 2020
@keithamus
Copy link
Owner

🎉 This PR is included in version 1.35.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fisker fisker deleted the fix-order-of-deps branch January 4, 2020 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisker @keithamus