fix: use locale-independent comparison for sorting of overrides (#327)

* fix: use locale-independent comparison for sorting of overrides

* Update index.js

Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>

---------

Co-authored-by: Jan Novotny <jan.novotny@oriflame.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>

Author: 3 people

index.js

@@ -77,7 +77,7 @@ const sortObjectBySemver = sortObjectBy((a, b) => {
   const { name: bName, range: bRange } = parseNameAndVersionRange(b)
 
   if (aName !== bName) {
-    return aName.localeCompare(bName)
+    return aName.localeCompare(bName, 'en')
   }
   if (!aRange) {
     return -1

tests/_helpers.js

@@ -53,8 +53,8 @@ function sortObjectAlphabetically(t, options = {}) {
   for (let depth = 1; depth < maxDepth + 1; depth++) {
     sortObject(t, {
       ...options,
-      value: keysToObject(['z', 'a'], depth),
-      expect: expect || keysToObject(['a', 'z'], depth),
+      value: keysToObject(['z', 'e', 'ch', 'a'], depth),
+      expect: expect || keysToObject(['a', 'ch', 'e', 'z'], depth),
     })
   }
 }
@@ -73,6 +73,10 @@ function sortObjectWithRangeAlphabetically(t, options = {}) {
           '@a-package@1.2.3',
           'b-package@1.2.3',
           '@b-package',
+          '@e-package@1.2.3',
+          '@ch-package@1.2.3',
+          'e-package@1.2.3',
+          'ch-package@1.2.3',
         ],
         depth,
       ),
@@ -82,10 +86,14 @@ function sortObjectWithRangeAlphabetically(t, options = {}) {
           [
             '@a-package@1.2.3',
             '@b-package',
+            '@ch-package@1.2.3',
+            '@e-package@1.2.3',
             '@z-package@1.2.3',
             'b-package@1.2.3',
             'b-package-package@1.2.3',
             'c-package@1.2.3',
+            'ch-package@1.2.3',
+            'e-package@1.2.3',
           ],
           depth,
         ),

tests/deps.js

@@ -44,3 +44,10 @@ test('dependenciesMetaRange', macro.sortObjectWithRangeAlphabetically, {
   // TODO: don't use snapshot, find a esaier way for review
   expect: 'snapshot',
 })
+
+test('pnpm.overrides', macro.sortObjectWithRangeAlphabetically, {
+  path: 'pnpm.overrides',
+  maxDepth: 2,
+  // TODO: don't use snapshot, find a esaier way for review
+  expect: 'snapshot',
+})