Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support domainname for runtime spec #5960

Open
liubin opened this issue Dec 27, 2022 · 4 comments
Open

Support domainname for runtime spec #5960

liubin opened this issue Dec 27, 2022 · 4 comments
Assignees
@dcantah
Labels
feature New functionality needs-review Needs to be assessed by the team.
Projects
Issue backlog

Comments

@liubin
Copy link
Member

liubin commented Dec 27, 2022

Refer to:

This need to add to both runtime and runtime-rs.
@liubin liubin added feature New functionality needs-review Needs to be assessed by the team. labels Dec 27, 2022
@dcantah
Copy link
Contributor

dcantah commented Jan 5, 2023

Can assign me here

@dcantah
Copy link
Contributor

dcantah commented Jan 5, 2023 •
edited

This need to add to both runtime and runtime-rs.

This shouldn't have a runtime component, right? I'd imagine it's just work in the agent (rustjail specifically).

Edit: See below, need to update protocols/pull in new runtime-spec as well

@dcantah
Copy link
Contributor

dcantah commented Jan 5, 2023

Ahh, I guess we'd need the updated spec

@liubin
Copy link
Member Author

liubin commented Jan 5, 2023

This need to add to both runtime and runtime-rs.

This shouldn't have a runtime component, right? I'd imagine it's just work in the agent (rustjail specifically).

Yes, if there is no need to update the domainame on the Golang runtime side, maybe we need only add the property to the agent protocol.

But for runtime-rs, the spec should add this new field. You can implement runtime/runtime-rs in two PRs.

BTW, the agent OCI protocol is here

dcantah added a commit to dcantah/kata-containers that referenced this issue Jan 5, 2023
@dcantah
Add runtime spec domainname support
16651b2 
Fixes: kata-containers#5960

This change adds support across the stack for the newly added domainname
field in the OCI runtime spec.

-Bumps runtime-spec to v1.0.3-0.20220909204839-494a5a6aca78 (main)
-Updates oci.proto for the guest protocol and libs/oci for the rust equivalents.

Signed-off-by: Danny Canter <danny@dcantah.dev>
@dcantah dcantah mentioned this issue Jan 5, 2023
Closed
dcantah added a commit to dcantah/kata-containers that referenced this issue Jan 5, 2023
@dcantah
Add runtime spec domainname support
378c458 
Fixes: kata-containers#5960

This change adds support across the stack for the newly added domainname
field in the OCI runtime spec.

-Bumps runtime-spec to v1.0.3-0.20220909204839-494a5a6aca78 (main)
-Updates oci.proto for the guest protocol and libs/oci for the rust equivalents.

Signed-off-by: Danny Canter <danny@dcantah.dev>
dcantah added a commit to dcantah/kata-containers that referenced this issue Jan 6, 2023
@dcantah
agent: Add runtime spec domainname support
1ff39ec 
Fixes: kata-containers#5960

This change adds support across the stack for the newly added domainname
field in the OCI runtime spec.

-Bumps runtime-spec to v1.0.3-0.20220909204839-494a5a6aca78 (main)
-Updates oci.proto for the guest protocol and libs/oci for the rust equivalents.

Signed-off-by: Danny Canter <danny@dcantah.dev>
dcantah added a commit to dcantah/kata-containers that referenced this issue Jan 6, 2023
@dcantah
agent: Add runtime spec domainname support
9777c08 
Fixes: kata-containers#5960

This change adds support across the stack for the newly added domainname
field in the OCI runtime spec.

-Bumps runtime-spec to v1.0.3-0.20220909204839-494a5a6aca78 (main)
-Updates oci.proto for the guest protocol and libs/oci for the rust equivalents.

Signed-off-by: Danny Canter <danny@dcantah.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcantah dcantah

Labels
feature New functionality needs-review Needs to be assessed by the team.
Projects
Issue backlog
  
To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

agent: Add runtime spec domainname support dcantah/kata-containers
2 participants
@liubin @dcantah