Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't run Linux Firefox on WSL #107

Closed
tstackhouse opened this issue Oct 22, 2019 · 6 comments
Closed

Can't run Linux Firefox on WSL #107

tstackhouse opened this issue Oct 22, 2019 · 6 comments
Labels
released

Comments

@tstackhouse
Copy link
Contributor

tstackhouse commented Oct 22, 2019 •
edited

There's no way to override the changes made in #96, I can set FIREFOX_BIN to use the linux firefox, but because of the wsl detection it tries to convert the profile path and causes the linux wires to get crossed.
@tstackhouse tstackhouse changed the title Can Can't run Linux Firefox on WSL Oct 22, 2019
@johnjbarton
Copy link
Contributor

What is a WSL?

@tstackhouse
Copy link
Contributor Author

What is a WSL?

Windows Subsystem for Linux. the referenced PR added a check for that platform and overrides the behaviour of the launcher to use the windows version of Firefox without even checking if a Linux version is available.

@birtles
Copy link
Collaborator

birtles commented Oct 22, 2019

Yeah, sorry about that. I didn't think anyone was actually trying to running Linux Firefox from WSL. It seems the majority of people are trying to run Windows Firefox but we should allow both.

@tstackhouse
Copy link
Contributor Author

No worries! I forked the repo to try to submit a PR, but I'm not familiar enough with how karma launchers work in order to make it a configurable option, or at least with how the check is currently implemented, as it seems like it happens at a global level (like the ternary in the launch commands) The naive way to implement it would be to simply check for the existence of firefox inside WSL before deferring to the windows version.

@birtles birtles mentioned this issue Oct 26, 2019
Open
@tstackhouse
Copy link
Contributor Author

Just wanted to follow up on this, I've got a potential fix that will work to bypass isWsl should firefox be installed in WSL. That said, I've noticed a caveat:

  • Firefox versions greater than 59 (probably more like 67/68) don't work, I know the most recent version (72 at the time of writing) doesn't. Running the command manually gives an "Exiting due to channel error." error, from what I can tell it's related to multi-process and DBus/IPC. Basically wonky low-level WSL stuff that will supposedly be fixed in WSL2.

I've been down this path mainly because running the windows Firefox, at least in the way my system is configured, where I'm also using Firefox as my primary browser, communication between Karma on WSL and Firefox on windows is janky at best, with sessions disconnecting, and Firefox spamming me with "XUL Runner Error" dialogs. I may need to spend some time investigating further to see why it fails like it does.

@tstackhouse tstackhouse mentioned this issue Jan 27, 2020
Closed
karmarunnerbot pushed a commit that referenced this issue Oct 20, 2020
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
fa165ba 
# [2.0.0](v1.3.0...v2.0.0) (2020-10-20)

### Bug Fixes

* Bypass WSL check if Firefox is present in WSL environment ([23a5d10](23a5d10)), closes [#107](#107)
* Update is-wsl to v2.2.0 to detect docker under WSL ([#116](#116)) ([c585393](c585393))

### Features

* Make Node 10 minimum required version ([480dafd](480dafd)), closes [#118](#118)

### BREAKING CHANGES

* Changed minimum required version of node.js from 8 to 10.

Node 8 EOL was 2019-12-31.
@karmarunnerbot
Copy link
Member

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tstackhouse @johnjbarton @birtles @karmarunnerbot