forked from cloudposse/terraform-aws-ecs-alb-service-task
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rebase cloudposse #10
Merged
Merged
+440
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add option to trigger a redeployment on apply * add triggers var to each variation of ecs_service * set redeployment trigger value in locals * Update example version and fixture * Update readme * Bump min tf version to 0.14 doc: rebuild readme * Run pr/auto-format/host locally
* Add option to trigger a redeployment on apply (cloudposse#193) * Add option to trigger a redeployment on apply * add triggers var to each variation of ecs_service * set redeployment trigger value in locals * Update example version and fixture * Update readme * Bump min tf version to 0.14 doc: rebuild readme * Run pr/auto-format/host locally * Modify task_policy_arns to use map - avoid Terraform for_each error related to dependency on resources known after apply - deprecate var task_policy_arns - replace with task_policy_arns_map * Use map instead of list for task_policy_arns * Replace task_exec_policy_arns with task_exec_policy_arns_map - deprecate task_exec_policy_arns - add test input for task_policy_arns * Rename test policy statement * Update readme * Auto Format * bump tf version for examples --------- Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
* feat(ecs_task_definition): add ipc_mode, pid_mode * fix(variables.tf): formatting * fix(tflint): change to square braces * fix(tflint): resolve remaining issues * chore(readme): update for commit checks * fix(variables): properly handle null
* feat: support ECS service connect * fix: manually update .md files to the expected values * fix: revert space changes
* fix: make `elb_name` optional * readme --------- Co-authored-by: Kevin Mahoney <kevin@icecube.dog>
Co-authored-by: max-lobur <max-lobur@users.noreply.github.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0. - [Commits](golang/net@v0.7.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.17.0 to 0.23.0. - [Commits](golang/net@v0.17.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: support ECS service connect TLS * feat: support ECS service connect timeout --------- Co-authored-by: Alex Kaplan <akaplan@akiliinteractive.com>
* feat: adds support for track_latest * chore: revert TF constraint update
…loudposse#251) REF: hashicorp/terraform-provider-aws#28070 Co-authored-by: RoseSecurity <72598486+RoseSecurity@users.noreply.github.com>
…e resource (cloudposse#256) * feat: add availability_zone_rebalancing * chore: typo * chore: set default null * chore: add attribute to additional resources
# Conflicts: # README.md # docs/terraform.md
mfroembgen
approved these changes
Feb 25, 2025
mfroembgen
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request