Standardize Property Inspector placeholder according to TOC #16566
Conversation
|
Thanks for making a pull request to jupyterlab! |
github-actions
bot
added
tag:CSS
|
I would go ahead and change the text to something more useful and following the convention as in TOC, e.g.:
Unless you would like this PR to be backported to 4.2.x as-is and then make a new PR with the updated text (to avoid breaking experience of users who use language packs we do not change translatable strings in the main parts of the UI in backports). |
|
I can implement this change too, no problem, @krassowski! Personally, I have no need for this PR to be backported to JupyterLab 4.2 (for context, we are working with JupyterLab 4.1 and the plan is to upgrade to 4.3 when possible). Let me know if I can make the change you suggested or if you would prefer to proceed another way. Btw, after adding/changing a translatable string, do I need to open a PR on the https://github.com/jupyterlab/language-packs side? |
Sure, let's target 4.3 with this PR and add the text changes here. No, no need to open PR on language packs, it is all automated. |
|
@krassowski, the PR is ready for a new review! I changed the text you suggested implementing a bit to, from my perspective, make it more consistent with the Table of Contents one, that is, the header in Title Case and the text starting with "The": 
Let me know your thoughts, please! |
…ab#16566) * Standardize Property Inspector placeholder according to TOC * Add placeholder headline and update placeholder text for the Property Inspector * Update snapshot --------- Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com>
Hi! 👋
References
Closes #14235
Code changes
The Property Inspector placeholder styling was adapted based on the Table of Contents placeholder as well as the HTML elements that make up it to take advantage of
<p>styles and for consistency.Let me know your feedback, please!
User-facing changes
The Property Inspector placeholder is now visually and element-wise similar to the Table of Contents placeholder:
Backwards-incompatible changes
Yes, given that translatable strings have changed.