Backport PR #15524: Fix visual tests #15578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Try to make the test terminal snapshot more robust by mock `tree . -L 2` command * Workaround `test-` dirs issue by capturing `/data` instead of `/` * Update Playwright Snapshots * Run customization docs snapshots in serial * Ignore all test files in galata tests * Update Playwright Snapshots * Disable concurrency in `build:examples` to fix flaky test This was already use in `build:src` * Ensure no flaky focus indicator on snapshot (cherry picked from commit c26a0e7)
|
Thanks for making a pull request to jupyterlab! |
|
bot please update documentation snapshots |
|
Documentation snapshots updated. |
|
bot please update galata snapshots |
|
Galata snapshots updated. |
|
Some documentation snapshots are still flaky but the main visual regression tests job passes - merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #15524 on branch 4.0.x (Fix visual tests,
allow to disable termianal cursor blinking)