Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt ruff format #15499

Merged
merged 1 commit into from Dec 7, 2023
Merged

Adopt ruff format #15499

merged 1 commit into from Dec 7, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Dec 7, 2023

References

Fixes #15498

Similar to jupyter/notebook#7132

Code changes

Minor tooling simplification by dropping black and using ruff format instead.

https://docs.astral.sh/ruff/formatter/

The Ruff formatter is an extremely fast Python code formatter designed as a drop-in replacement for Black, available as part of the ruff CLI (as of Ruff v0.0.289).

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added this to the 4.0.x milestone Dec 7, 2023
fcollonval
fcollonval approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio

Let's backport it to ease 4.x maintenance.

@fcollonval fcollonval merged commit 5ec3aa4 into jupyterlab:main Dec 7, 2023
76 of 81 checks passed
@fcollonval
Copy link
Member

@meeseeksdev please backport to 4.0.x

@lumberbot-app Lumberbot (App)
Copy link

lumberbot-app bot commented Dec 7, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 4.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 5ec3aa40ffcea1a30cde7c391a63e8bbda897ea8
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #15499: Adopt ruff format'
  1. Push to a named branch:
git push YOURFORK 4.0.x:auto-backport-of-pr-15499-on-4.0.x
  1. Create a PR against branch 4.0.x, I would have named this PR:

"Backport PR #15499 on branch 4.0.x (Adopt ruff format)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@jtpio jtpio deleted the ruff-format branch December 7, 2023 12:45
@jtpio jtpio mentioned this pull request Dec 12, 2023
Merged
chisangajm3 added a commit to chisangajm3/jupyterlab that referenced this pull request Dec 18, 2023
@chisangajm3
Merge remote-tracking branch 'upstream/main' into 1.0.x
da3005a 
* upstream/main: (7628 commits)
  Adopt ruff format (jupyterlab#15499)
  Bump scipy from 1.11.3 to 1.11.4 (jupyterlab#15474)
  [pre-commit.ci] pre-commit autoupdate (jupyterlab#15491)
  Pin `actions/labeler` to v4 to fix failing CI action (jupyterlab#15496)
  Add npm provenance issue to the list of release postmortems (jupyterlab#15493)
  Fix URLs in debugger-extension (jupyterlab#15462)
  Bump tj-actions/changed-files from 40.0.2 to 40.2.0 (jupyterlab#15471)
  Bump dessant/lock-threads from 4 to 5 (jupyterlab#15472)
  Bump pandas from 2.1.2 to 2.1.3 (jupyterlab#15473)
  Bump actions/github-script from 6 to 7 (jupyterlab#15470)
  Bump matplotlib from 3.7.2 to 3.8.2 (jupyterlab#15475)
  Bump rjsf to 5.13.4 (jupyterlab#15469)
  Don't play with the focus when handling focus event (jupyterlab#15408)
  [ci skip] Publish 4.1.0a4
  Updated light theme visited link colour to make text visible (jupyterlab#15406)
  Load custom CSS functionality and documentation (jupyterlab#14743)
  Added alt descriptions to a few icon and images (jupyterlab#15265)
  More robust galata/UI tests (jupyterlab#15355)
  Fix Shift + L not working in stdin (jupyterlab#15440)
  Upgrade releaser workflows for silent support (jupyterlab#15446)
  ...
krassowski pushed a commit to krassowski/jupyterlab that referenced this pull request Dec 26, 2023
@jtpio @krassowski
Backport PR jupyterlab#15499: Adopt ruff format
59ff2dc 
(cherry picked from commit 5ec3aa4)
@krassowski krassowski mentioned this pull request Dec 26, 2023
Merged
krassowski added a commit that referenced this pull request Dec 27, 2023
@krassowski @jtpio
Backport PR #15499: Adopt ruff format (#15564)
3ce0331 
(cherry picked from commit 5ec3aa4)

Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@jtpio jtpio

Labels
documentation maintenance tag:Examples
Projects
None yet
Milestone
4.0.x
Development

Successfully merging this pull request may close these issues.

Adopt Ruff format
3 participants
@jtpio @fcollonval @krassowski