Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search too often switches cells in edit mode #15457

Open
parmentelat opened this issue Nov 29, 2023 · 0 comments
Open

Search too often switches cells in edit mode #15457

parmentelat opened this issue Nov 29, 2023 · 0 comments

Comments

@parmentelat
Copy link
Contributor

Problem

when using Search dialog to "go to" a match, current behaviour seems to be to unconditionally switch target cell to edit mode if it's a markdown cell (for code cells I'm not quite sure; I can never say for sure when a code cell is in edit mode, as the visual difference between both modes is hardly noticeable for me)

I think I understand that in the case of markdown cells, it is quite possible to have some text appear in the source but not in the rendered version; and this might be the rationale behind this systematic switch to edit mode

however one can argue this approach is very intrusive, esp. as the actual situations where it does happen (that the searched text is present in the source but not rendered) are far from dominant

Proposed Solution

not quite sure how to improve, except that I'd rather have the cell go to edit mode only when necessary..

Additional context

touched on in #15443

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Nov 29, 2023
@JasonWeill JasonWeill added tag:Search and Replace and removed status:Needs Triage Applied to new issues that need triage labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants