-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide completer when changing notebook tabs #14534
Hide completer when changing notebook tabs #14534
Conversation
Thanks for making a pull request to jupyterlab! |
…re other mousedown events with preventDefault and stopPropogation
8fe8de6
to
1f3dc59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well for me, I don't think this would cause any trouble with Notebook 7.
I will wait for a second look from @fcollonval as per discussion on the issue: #14496 (comment)
Two weeks have passed, no objections - I am merging this because I believe this simply restores previous behaviour after transition from |
@meeseeksdev please backport to 4.0.x |
Co-authored-by: Nishikant Parmar <nishikantparmar123@gmail.com>
@meeseeksdev please backport to 3.6.x |
… changing notebook tabs) (#15244) * Backport PR #14534: Hide completer when changing notebook tabs * Backport PR #15237: Fix completer tests after transition to pointer events Cherry-picked from commit 206368a. --------- Co-authored-by: Nishikant Parmar <nishikantparmar123@gmail.com> Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
References
Closes #14496