Fix save as without changing the file name #14212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
fcollonval
requested changes
Mar 16, 2023
There was a problem hiding this comment.
Thanks @hbcarlos
If we do that, could we remove the logical change introduced in https://github.com/jupyterlab/jupyterlab/pull/14182/files#diff-bd91309321cead1ad13aa66f461c81110113c117fababf12ea04e346b0b5afb5
aka switching back to
if (this.isDisposed || !newPath) {
return;
}instead of rejecting the promise.
And could you add a jest test that if the path is the same, no save event should be triggered.
I can help if you are not available.
fcollonval
changed the title
|
@meeseeksdev please backport to 3.6.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. The mean relative comparison is computed with 95% confidence. Results table
Changes are computed with expected as reference.
Waiting for localhost:8888 Cell memory leaksCreate a code cellMemory change: +152 kB Leak detected: YesLeaking objects:
Leaking collections: Create a markdown cellMemory change: -89.1 kB Leak detected: NoLeaking objects:
Leaking collections: Create a raw cellMemory change: +147 kB Leak detected: YesLeaking objects:
Leaking collections: File editor memory leaksCreate a fileMemory change: -79.3 kB Leak detected: NoLeaking objects:
Notebook memory leaksCreate a notebookMemory change: +32.8 kB Leak detected: YesLeaking objects:
2 passing (6m) |
fcollonval
added a commit
to fcollonval/jupyterlab
that referenced
this pull request
Mar 17, 2023
* Fixes saving with the same name * Review * Add test for dismissed save as dialog --------- Co-authored-by: Frédéric Collonval <fcollonval@gmail.com> (cherry picked from commit b80523f)
fcollonval
added a commit
that referenced
this pull request
Mar 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #14182
I just realized there is an issue. When saving the document with the same name, the Drive emits a
saveevent with the same name, so we close the document but do not open the new one.This fix will prevent closing the document if we are not opening a new one.
Grabacion.de.pantalla.2023-03-16.a.las.14.24.18.mov
cc @fcollonval
References
Code changes
User-facing changes
Backwards-incompatible changes