Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore @jupyterlab/shared-models as proxy to @jupyter/ydoc #14133

Merged
merged 3 commits into from Mar 17, 2023
Merged

Restore @jupyterlab/shared-models as proxy to @jupyter/ydoc #14133

merged 3 commits into from Mar 17, 2023

Conversation

fcollonval
Copy link
Member

References

Fixes jupyterlab/extension-examples#220
Related to #13971

Code changes

Restore @jupyterlab/shared-models to proxy @jupyter/ydoc

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added the bug label Mar 6, 2023
@fcollonval fcollonval added this to the 3.6.x milestone Mar 6, 2023
@fcollonval fcollonval marked this pull request as ready for review March 7, 2023 13:09
@fcollonval fcollonval mentioned this pull request Mar 8, 2023
Merged
hbcarlos
hbcarlos approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@hbcarlos hbcarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fcollonval!

@fcollonval fcollonval merged commit 45bd507 into jupyterlab:3.6.x Mar 17, 2023
@fcollonval fcollonval deleted the fix/backward-compatibility-shared-models branch March 17, 2023 15:42
@fcollonval fcollonval mentioned this pull request Mar 20, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hbcarlos hbcarlos hbcarlos approved these changes

Assignees

@fcollonval fcollonval

Labels
bug tag:Real Time Collaboration
Projects
None yet
Milestone
3.6.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fcollonval @hbcarlos