Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit selectKernel dialog to make sure it always has translator #10003

Closed
JessicaBarh opened this issue Mar 25, 2021 · 4 comments
Closed

Audit selectKernel dialog to make sure it always has translator #10003

JessicaBarh opened this issue Mar 25, 2021 · 4 comments

Comments

@JessicaBarh
Copy link
Contributor

Description

"Select Kernel" dialog does not display in selected UI language.
the options.translator seems to be null in:

this.translator = options.translator || nullTranslator;

image

image

Reproduce

  1. Go to File -> New -> Notebook
  2. "Select Kernel" dialog comes up

Expected behavior

image

This is the dialog displayed working correctly if opened by clicking on the kernel name at the top right corner of a notebook:
image

Context

  • JupyterLab version: 3.0.11
@jasongrout
Copy link
Contributor

It does look like there are a few places that selectKernel is being called without a translator: https://github.com/jupyterlab/jupyterlab/search?q=selectKernel%28

@jasongrout
Copy link
Contributor

My guess is the place you are seeing is from

void this._dialogs.selectKernel(this.sessionContext);

You could verify it by setting a breakpoint and looking at the stack trace, to see who is calling selectKernel without a translator argument.

@SRILEKHA-V19
Copy link

SRILEKHA-V19 commented Jun 20, 2021

I can take a look at this issue and give it a try :)
(Beginner at open source contribution to a large community using this tool)

@afshin afshin changed the title SessionContext.IOptions translator is undefined Audit selectKernel dialog to make sure it always has translator Jun 16, 2022
@fcollonval
Copy link
Member

Fix was included in #12858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants