Updated ui-tests Configuration in Contributing.md #7124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jtpio
reviewed
Oct 27, 2023
CONTRIBUTING.md
Outdated
| jlpm | ||
|
|
||
| #install playwright | ||
| npx playwright install |
There was a problem hiding this comment.
Maybe we can stick to jlpm for consistency here?
Suggested change
| npx playwright install | |
| jlpm playwright install |
There was a problem hiding this comment.
Thanks @jtpio for pointing out.
…ngh9767/notebook into update_contributing_doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While setting up UI tests on my Local System, I have faced issue while using jlpm, Got to know from @krassowski that we need to install Packages of jlpm inside folder
ui-tests.So, This PR will update the CONTRIBUTING.md so that future contributors doesn't face the same.