Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-authorize merge commits to main branch #269

Closed
12rambau opened this issue Jan 10, 2024 · 4 comments
Closed

re-authorize merge commits to main branch #269

12rambau opened this issue Jan 10, 2024 · 4 comments
Assignees

Comments

@12rambau
Copy link
Contributor

@blink1073 could you change the rules applied to the main branch and re-authorize merge commits as discussed in #237. I wanted to start merging bigger PR and only squash merges are allowed on main.

As a maintainer, I can do it in global config but I don't have enough rights to change branch rules.

@blink1073
Copy link
Member

image

As I said, I think "Rebase and merge" is a much better option, it preserves the order of the history without having a merge commit.

@12rambau
Copy link
Contributor Author

12rambau commented Jan 10, 2024

I tried on #268 and it's creating a conflict that cannot be solved from the GH interface. As @akhmerov and I were ok to go back to the previous workflow I thought it was just a matter of applying it. I'm sorry if I look stubborn but I really don't see the advantage of forcing the use of either squash or rebase compared to merge considering the drawbacks I already mentioned and seeing now that it requires extra work to do something that is transparent with the default merge.

EDIT: And writting that I'm asking myself in the absense of a merge commit will the autogenerated changelog from github continue to work?

@blink1073
Copy link
Member

I will disagree and move on, I changed the policy.

@12rambau
Copy link
Contributor Author

thanks a lot, I'm sure your method is better, we simply didn't face the need so we behave like spoiled child ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants