Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send2trash now supports deleting from different filesystem type #1290

Closed
wqj97 opened this issue Jun 21, 2023 · 1 comment
Closed

send2trash now supports deleting from different filesystem type #1290

wqj97 opened this issue Jun 21, 2023 · 1 comment
Labels

Comments

@wqj97
Copy link
Contributor

wqj97 commented Jun 21, 2023

Description

Move to Trash on Linux has an inaccurate condition:

If the deleted file is not in the same file system as the HOME folder, there will be no trash enable:
filemanager:979

But now in the implementation of move2trash, it will get the mount point and move over
send2Trash:210

Reproduce

  1. mount an nfs to dist: such as /home/admin/workspace (nfs)
  2. start jupyter server
  3. delete file
  4. skip trash, and got a warning: Skipping trash for /home/admin/workspace/xxx.ipynb, on different device to home directory

Expected behavior

Remove condition or add a config to force send to trash.

Context

I will create a PR later
#1291

@wqj97 wqj97 added the bug label Jun 21, 2023
@welcome
Copy link

welcome bot commented Jun 21, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@wqj97 wqj97 changed the title Move to Trash on Linux has an inaccurate condition send2trash now supports deleting directories (#) Jun 21, 2023
wqj97 pushed a commit to wqj97/jupyter_server that referenced this issue Jun 21, 2023
@wqj97 wqj97 changed the title send2trash now supports deleting directories (#) send2trash now supports deleting from different filesystem type Jun 22, 2023
wqj97 pushed a commit to wqj97/jupyter_server that referenced this issue Jun 24, 2023
blink1073 pushed a commit that referenced this issue Jun 27, 2023
#1291)

Co-authored-by: qianjun.wqj <qianjun.wqj@alibaba-inc.com>
@wqj97 wqj97 closed this as completed Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant