Improve item width size estimation heuristic support #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was that: - (a) heuristic did not account for eliding - (b) styles limiting the width were not applied when the widest item size was calculated after temporarily re-parenting to `<body>` - (c) there was no limit on ellipsis width (now its 50% of label) - (d) the label size limit maybe was too low, it got increased by 50px
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #1002
Code changes
The issue was that:
<body>User-facing changes
Eliding of paths works better. There should be no empty (unutilised) space in the completer anymore
Backwards-incompatible changes
None