Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the minmium supported node version to 18.17.0 for development #562

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

luckrnx09
Copy link
Contributor

If someone wants to contribute code to the project, and they follow the README's guidelines for local development, an error was occurred while run the pnpm build command in the repository root directory:

www:build: /Users/<username>/usehooks-ts/apps/www
www:build: You are using Node.js 16.15.0. For Next.js, Node.js version >= v18.17.0 is required.

Update the minimum supported node version to make people smoothly run all code and preview the document locally.

Copy link

changeset-bot bot commented Mar 27, 2024

⚠️ No Changeset found

Latest commit: 0bf0c11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@luckrnx09 luckrnx09 changed the title fix: update the minium node version to 18.17.0 for development fix: update the minmium supported node version to 18.17.0 for development Mar 27, 2024
@luckrnx09
Copy link
Contributor Author

luckrnx09 commented Mar 27, 2024

Not sure if the package.json in the packages/usehooks-ts should do the same update.
Because I don't know if I do that it will force users who are installing usehooks-ts from the npm package to upgrade their local version of nodejs.

If anyone knows, please guide me. Thanks!

@luckrnx09 luckrnx09 marked this pull request as ready for review March 27, 2024 14:22
@juliencrn juliencrn merged commit 6ba53d5 into juliencrn:master Apr 4, 2024
1 check failed
@juliencrn
Copy link
Owner

@all-contributors please add @luckrnx09 for code

Copy link
Contributor

@juliencrn

I've put up a pull request to add @luckrnx09! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants