-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: react/no-unknown-property
doesn't recognize <template shadowrootmode=...>
#3912
Closed
2 tasks done
Labels
Comments
when fixing this, let's add all the shadow root attributes listed here |
TildaDares
pushed a commit
to TildaDares/eslint-plugin-react
that referenced
this issue
Mar 25, 2025
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this issue
Apr 4, 2025
| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | eslint-plugin-react | 7.37.4 | 7.37.5 | ## [v7.37.5](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7375---20250403) ##### Fixed - \[`no-unknown-property`]: allow shadow root attrs on `<template>` ([#3912][] [@ljharb](https://github.com/ljharb)) - \[`prop-types`]: support `ComponentPropsWithRef` from a namespace import ([#3651][] [@corydeppen](https://github.com/corydeppen)) - \[`jsx-no-constructed-context-values`]: detect constructed context values in React 19 `<Context>` usage ([#3910][] [@TildaDares](https://github.com/TildaDares)) - \[`no-unknown-property`]: allow `transform-origin` on `rect` ([#3914][] [@ljharb](https://github.com/ljharb)) ##### Changed - \[Docs] \[`button-has-type`]: clean up phrasing ([#3909][] [@hamirmahal](https://github.com/hamirmahal)) [7.37.5]: jsx-eslint/eslint-plugin-react@v7.37.4...v7.37.5 [#3914]: jsx-eslint/eslint-plugin-react#3914 [#3912]: jsx-eslint/eslint-plugin-react#3912 [#3910]: jsx-eslint/eslint-plugin-react#3910 [#3909]: jsx-eslint/eslint-plugin-react#3909 [#3651]: jsx-eslint/eslint-plugin-react#3651
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this issue
Apr 5, 2025
| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | eslint-plugin-react | 7.37.4 | 7.37.5 | ## [v7.37.5](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7375---20250403) ##### Fixed - \[`no-unknown-property`]: allow shadow root attrs on `<template>` ([#3912][] [@ljharb](https://github.com/ljharb)) - \[`prop-types`]: support `ComponentPropsWithRef` from a namespace import ([#3651][] [@corydeppen](https://github.com/corydeppen)) - \[`jsx-no-constructed-context-values`]: detect constructed context values in React 19 `<Context>` usage ([#3910][] [@TildaDares](https://github.com/TildaDares)) - \[`no-unknown-property`]: allow `transform-origin` on `rect` ([#3914][] [@ljharb](https://github.com/ljharb)) ##### Changed - \[Docs] \[`button-has-type`]: clean up phrasing ([#3909][] [@hamirmahal](https://github.com/hamirmahal)) [7.37.5]: jsx-eslint/eslint-plugin-react@v7.37.4...v7.37.5 [#3914]: jsx-eslint/eslint-plugin-react#3914 [#3912]: jsx-eslint/eslint-plugin-react#3912 [#3910]: jsx-eslint/eslint-plugin-react#3910 [#3909]: jsx-eslint/eslint-plugin-react#3909 [#3651]: jsx-eslint/eslint-plugin-react#3651
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this issue
Apr 6, 2025
| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | eslint-plugin-react | 7.37.4 | 7.37.5 | ## [v7.37.5](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7375---20250403) ##### Fixed - \[`no-unknown-property`]: allow shadow root attrs on `<template>` ([#3912][] [@ljharb](https://github.com/ljharb)) - \[`prop-types`]: support `ComponentPropsWithRef` from a namespace import ([#3651][] [@corydeppen](https://github.com/corydeppen)) - \[`jsx-no-constructed-context-values`]: detect constructed context values in React 19 `<Context>` usage ([#3910][] [@TildaDares](https://github.com/TildaDares)) - \[`no-unknown-property`]: allow `transform-origin` on `rect` ([#3914][] [@ljharb](https://github.com/ljharb)) ##### Changed - \[Docs] \[`button-has-type`]: clean up phrasing ([#3909][] [@hamirmahal](https://github.com/hamirmahal)) [7.37.5]: jsx-eslint/eslint-plugin-react@v7.37.4...v7.37.5 [#3914]: jsx-eslint/eslint-plugin-react#3914 [#3912]: jsx-eslint/eslint-plugin-react#3912 [#3910]: jsx-eslint/eslint-plugin-react#3910 [#3909]: jsx-eslint/eslint-plugin-react#3909 [#3651]: jsx-eslint/eslint-plugin-react#3651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Description Overview
shadowrootmode
attribute of<template>
is in Baseline 2024, so I expected eslint-plugin-react to recognize it.Code:
package.json:
eslint.config.js:
src/example.jsx:
results in
Playground: https://eslint-online-playground.netlify.app/#eNqNUctugzAQ/JWVLyQRjztNoh76Cb3FOSBYUgheI9s0RBH/3rUDkVpFVSSwLc/Mznr2JqwpMxwL1XeYtnYUucCx18ZBqck6+ERGCoewg9UadntYSQLYuuXafhWVvhitndIV7qTQPZIU+222UPaS1m+SRCzQdg25lAvXzYnN2KtRwau1UButQIr3OylrrRSsmnGDRekWyp2R9N1waigJUODOfVdYF0Pn4OAbbe1sZ1ODpVYKqcIq9lAQPtCaW32Bcog4o8QM5BqF0TGwbn4BqJsObQ6HaLPJNumttTFTY8V7yb/z3zjNEi49BPasBYiCV0Y6GehM+kJJbzhK465RDhEao000S2EKB78e78H2RXkuTn5+mjjUUFQKd+1RipxPPBq2kyLopKjw+wN5TBVS2SAH/ejjd/5e6idoOd/Ze0n/X/DPaJ4yn2DhUZImMf0AvA3e4w==
Expected Behavior
shadowrootmode, shadowrootclonable, and shadowrootdelegatesfocus should be recognized (but probably not experimental
shadowrootserializable
).eslint-plugin-react version
7.37.4
eslint version
9.23.0
node version
20.16.0
The text was updated successfully, but these errors were encountered: