Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick question: does settings.version default to "detect" yet? #3758

Closed
JstnMcBrd opened this issue May 17, 2024 · 3 comments
Closed

Quick question: does settings.version default to "detect" yet? #3758

JstnMcBrd opened this issue May 17, 2024 · 3 comments

Comments

@JstnMcBrd
Copy link

In the README, it says that sometime in the future, version will default to detect instead of latest.

{
  "settings": {
    "react": {
      // ...
      "version": "detect", // React version. "detect" automatically picks the version you have installed.
                           // You can also use `16.0`, `16.3`, etc, if you want to override the detected value.
                           // It will default to "latest" and warn if missing, and to "detect" in the future
      // ...
    },
    // ...
}

That would be a very useful change! But I don't know how long ago this part of the README was written. Have you already made this update? If not, are you still planning on it?

@ljharb
Copy link
Member

ljharb commented May 17, 2024

Nope, if the change was made the readme would be updated.

This change can’t happen until a semver-major, and i almost never do those. Also, the recommended way to use this plugin is via the Airbnb config which already sets it to detect.

@JstnMcBrd
Copy link
Author

I can't find anything in the readme about an airbnb config. Where is it recommended?

@ljharb
Copy link
Member

ljharb commented May 17, 2024

It's not written in the readme, that's true :-) but i recommend it.

@JstnMcBrd JstnMcBrd closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants