[Docs] jsx-key: fix correct example
#3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3656 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 132 132
Lines 9375 9375
Branches 3432 3432
=======================================
Hits 9155 9155
Misses 220 220 ☔ View full report in Codecov by Sentry. |
ljharb
approved these changes
Nov 21, 2023
ljharb
force-pushed
the
fix/jsx-key-correct-example
branch
from
54b4984
to
48318fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 3rd item of the correct example,
x.idis used as the key. However, since an number type array is entered in Array.from, x is a number, all keys have undefined. Additionally, searching the number property is generally considered an error in TypeScript.Therefore, the key was modified to use
xitself so that the key has a unique value and does not cause an error in TypeScript.