[New] prefer-read-only-props, prop-types, component detection: allow components to be async functions

[pnodet]

React introduced server components, now async functions can be components.

Closes #3653

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ff9ef9) 97.65% compared to head (ef4db36) 97.65%.

❗ Current head ef4db36 differs from pull request most recent head 3fb79e1. Consider uploading reports for the commit 3fb79e1 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3654      +/-   ##
==========================================
- Coverage   97.65%   97.65%   -0.01%     
==========================================
  Files         132      132              
  Lines        9378     9375       -3     
  Branches     3433     3432       -1     
==========================================
- Hits         9158     9155       -3     
  Misses        220      220              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pnodet]

@ljharb
I am not familiar with the AST, but we could indeed make a stricter check.

One thing that comes to my mind is checking the return statement of the function, since it should return null or a JSX Element to be valid, but I have no idea how feasible this is.

As you mentioned, async generator functions (async function*) are not valid as React components. This is a clear exclusion criterion.

[ljharb]

As long as the proper test cases are in the PR, it's ok if they're failing; I can try to bring it over the finish line.

[ljharb]

Note that react components as of v16 can return almost anything - including an array of renderable things - so checking the return statement is no longer a disqualifier.

[pnodet]

Note that react components as of v16 can return almost anything - including an array of renderable things - so checking the return statement is no longer a disqualifier.

Okay, I updated the PR to allow only async generators.

[pnodet]

Hello @ljharb

I see that 1 check is failing, if I am not mistaken due to a lower code coverage percentage.
I'am not sure what test should be added for this to be honest, but I can try to implement some if you have suggestions

[pnodet]

Hello @ljharb Hope you're doing well!
I was wondering when do you think the next release including this changes would be?
Is there ongoing work you're waiting for and where I could help?

[ljharb]

@pnodet i don't have a timeline, but I'll try to do it soon.