Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] add requireDataLowercase option to no-unknown-property rule #3645

Merged
merged 1 commit into from Nov 9, 2023
Merged

[New] add requireDataLowercase option to no-unknown-property rule #3645

merged 1 commit into from Nov 9, 2023

Conversation

HermanBilous
Copy link
Contributor

Fixes #3643

@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited

Codecov Report

Merging #3645 (eaf977b) into master (ca30f77) will not change coverage.
The diff coverage is 100.00%.

❗ Current head eaf977b differs from pull request most recent head 70e6019. Consider uploading reports for the commit 70e6019 to get more accurate results

@@           Coverage Diff           @@
##           master    #3645   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         132      132           
  Lines        9369     9369           
  Branches     3429     3431    +2     
=======================================
  Hits         9149     9149           
  Misses        220      220
Files Coverage Δ
lib/rules/no-unknown-property.js 98.93% <100.00%> (+0.11%) ⬆️

... and 4 files with indirect coverage changes

ljharb
ljharb requested changes Oct 21, 2023
View reviewed changes
lib/rules/no-unknown-property.js Outdated Show resolved Hide resolved
tests/lib/rules/no-unknown-property.js Outdated Show resolved Hide resolved
@HermanBilous HermanBilous changed the title [New] add allowDataUpperCase option to no-unknown-property rule [New] add requireDataLowercase option to no-unknown-property rule Oct 24, 2023
@HermanBilous
Copy link
Contributor Author

Hey, @ljharb, could you take a look? I addressed all your comments.

ljharb
ljharb reviewed Oct 30, 2023
View reviewed changes
docs/rules/no-unknown-property.md Outdated Show resolved Hide resolved
lib/rules/no-unknown-property.js Outdated Show resolved Hide resolved
@ljharb ljharb merged commit 70e6019 into jsx-eslint:master Nov 9, 2023
311 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: no-unknown-property gives false-positives on data-* attributes, but React gives warnings on them
2 participants
@HermanBilous @ljharb