[New] no-invalid-html-attribute: add support for apple-touch-startup-image rel attributes in link tags
#3638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up-image` `rel` attributes in `link` tags
Codecov Report
@@ Coverage Diff @@
## master #3638 +/- ##
=======================================
Coverage 97.64% 97.64%
=======================================
Files 132 132
Lines 9360 9360
Branches 3427 3427
=======================================
Hits 9140 9140
Misses 220 220
|
ljharb
changed the title
no-invalid-html-attribute: add support for apple-touch-startup-image rel attributes in link tags
ljharb
added
the
hacktoberfest-accepted
|
The failing tests are unrelated to this PR; I'll fix them on master after landing this. |
thomashockaday
deleted the
feature/add-support-for-apple-touch-startup-image
branch
|
Hey guys, sorry to be bothering, I don't know how the releases works here. Just pinging to know if we have a prevision when this fix will become to a release. |
|
There’s no timeline; it’ll be included in the next release. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this attribute fails on the latest version:
According to the docs the accepted values for this rule come from MDN, and MDN states that this value is non-standard but not disallowed, the same as
apple-touch-icon.If I am incorrect here please let me know.
To test this I've added a generic example as seen in Apple's own documentation as well as a longer example more like something that a PWA asset generator would give you (which is recommended by web.dev).