New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.10.1 breaks v6.10.0 builds (related to jsx-indent) #1117
Comments
This also is breaking react-dates react-dates/react-dates#383 |
due to an issue - jsx-eslint/eslint-plugin-react#1117
Looking at it. |
@yannickcr i'm afraid this still isn't fixed. This code is still warning on jsx-indent, newly in 6.10+. |
Closes #383. Related to jsx-eslint/eslint-plugin-react#1117.
(there's a number of other examples in that repo; clone at this sha and run |
Crap, you're right. Seems to be another issue with multi-line tags. I'll made another patch release shortly. but there is a good chance it will be done tomorrow (it's getting late here). |
We're still experiencing this bug with <div>
{myText} of {myOtherText} completed before something else
</div>
// Expected indentation of 12 space characters but found 1 react/jsx-indent |
It seems 6.10.1-2 has the bug, so temporarily fix the version (jsx-eslint/eslint-plugin-react#1117)
@atkinchris I'm still experiencing problems as well. My sample:
|
Still seeing the issue with version 6.10.2 also. Reverting to 6.9.0 works. Reverting for now. |
@yannickcr #1118 has some extra test cases. |
The docs at https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-indent.md appear to be indicating that this is the default behavior. Tracing through version history, it looks to me like indentLogicalExpressions was added as an option at 6.10.1 and the default setting of "false" would elicit the behavior reported in this thread. I have changed my eslintrc.json file to contain: and the behavior reverts to this not being an error (as expected based on the documentation). Since making "false" the default behavior appears to introduce a breaking change, perhaps making "true" the default behavior would not? |
Adds the Calendar component Updates the example to show the dates (not final) Changes the DaysPanel to export directly the class Makes the code more explicit on the calendar.js Makes the styles customizable Fixes the _default.yaml to be able to build Fixes SCSS to build :D Changes the builder to actually output (and colorize) when an error happens Adds classNames to elements to make them more specific Fixes bug where an error would be triggered when the initialDates attribute was not set. Also resets the minLimit to the passed one when provided via attributes or to null when none is available Hides the nav button when not enabled Changes the _default.yaml to have decent colors for the rendering :P Adds the function leftPad() to the helpers to do left padding of the months and days Improves the code based on the reviews' feedback. Also makes it more testable and fixes some bugs detected when developing the unit tests Converts the DaysPanel to a stateless component with no mods (for now) Improves the code based on reviews' feedback. Also makes it more testable and introduces a new method to merge the locale definitions Removes the enzyme-to-json package and brings jest-serializdr-enzyme which is then configured in the jest config Reverts the removal to give time to migrate the other unit tests. Adds the serializer configuration to the jest.config.json Adds the unit tests and its snapshots Updates the tests for UTC Removes the mods and the dataAttrs from the 'defaultProps'. Updates the snapshots Attempt to set some colors matching the defined color pattern Updates the snapshots Adds some aria-labels to increase accessibility Adds updated snapshots Fixes a lint error :P Adds a function to normalize the dates on the time Changes the code to use the newly added function Updates the tests to use the normalizeDate() and updates the snapshots Moves the 'bind' to its own declaration, to prevent warnings from linting Changed the 'extraClasses' variable to be named 'mods' Changes the 'npm test' to set the testing to be always UTC (to solve CI issues) Also added the TZ=utc to the update-snapshots script Adds a function processProps() to be used by both the constructor and the componentWillReceiveProps() from the Calendar component Adds a wrapper component to make the test of the props being changed. Also adds a test to verify the componentWillReceiveProps. Updates the snapshots Improves coverage of the componentWillReceiveProps Downgraded eslint-plugin-react due to a bug on the jsx-indent rule: jsx-eslint/eslint-plugin-react#1117 Fixes the issue with the eslint-plugin-react's version, enabling the indentLogicalExpressions Adds the possibility to override the display text in the navigation buttons, as well as the aria-label attribute
Reverted #1058 since it introduced this issue. I'll publish the updated version and I'll work on a patch to get this properly fixed. |
|
Thanks, all fixed! |
Massive props to @yannickcr for the quick turn around time - thank you so much for the hard work you put into this module 🎉 |
* Changes the builder to use the util.inspect() to output the error Adds the Calendar component Updates the example to show the dates (not final) Changes the DaysPanel to export directly the class Makes the code more explicit on the calendar.js Makes the styles customizable Fixes the _default.yaml to be able to build Fixes SCSS to build :D Changes the builder to actually output (and colorize) when an error happens Adds classNames to elements to make them more specific Fixes bug where an error would be triggered when the initialDates attribute was not set. Also resets the minLimit to the passed one when provided via attributes or to null when none is available Hides the nav button when not enabled Changes the _default.yaml to have decent colors for the rendering :P Adds the function leftPad() to the helpers to do left padding of the months and days Improves the code based on the reviews' feedback. Also makes it more testable and fixes some bugs detected when developing the unit tests Converts the DaysPanel to a stateless component with no mods (for now) Improves the code based on reviews' feedback. Also makes it more testable and introduces a new method to merge the locale definitions Removes the enzyme-to-json package and brings jest-serializdr-enzyme which is then configured in the jest config Reverts the removal to give time to migrate the other unit tests. Adds the serializer configuration to the jest.config.json Adds the unit tests and its snapshots Updates the tests for UTC Removes the mods and the dataAttrs from the 'defaultProps'. Updates the snapshots Attempt to set some colors matching the defined color pattern Updates the snapshots Adds some aria-labels to increase accessibility Adds updated snapshots Fixes a lint error :P Adds a function to normalize the dates on the time Changes the code to use the newly added function Updates the tests to use the normalizeDate() and updates the snapshots Moves the 'bind' to its own declaration, to prevent warnings from linting Changed the 'extraClasses' variable to be named 'mods' Changes the 'npm test' to set the testing to be always UTC (to solve CI issues) Also added the TZ=utc to the update-snapshots script Adds a function processProps() to be used by both the constructor and the componentWillReceiveProps() from the Calendar component Adds a wrapper component to make the test of the props being changed. Also adds a test to verify the componentWillReceiveProps. Updates the snapshots Improves coverage of the componentWillReceiveProps Downgraded eslint-plugin-react due to a bug on the jsx-indent rule: jsx-eslint/eslint-plugin-react#1117 Fixes the issue with the eslint-plugin-react's version, enabling the indentLogicalExpressions Adds the possibility to override the display text in the navigation buttons, as well as the aria-label attribute * Adds the examples with a normal calendar with all props set and a range calendar with all props set * Fixes issue where renderDate was not between the min and max limits, so needed to be readjusted * Fixes issue where in the edge-months (0 and 11) we were doing improper math :D * Updates the snapshots and the tests to cover properly with the new changes * Fixes poor configuration on the .eslintrc * Improved readability on the ternary operator of the handling of the renderDate
* Changes the builder to use the util.inspect() to output the error Adds the Calendar component Updates the example to show the dates (not final) Changes the DaysPanel to export directly the class Makes the code more explicit on the calendar.js Makes the styles customizable Fixes the _default.yaml to be able to build Fixes SCSS to build :D Changes the builder to actually output (and colorize) when an error happens Adds classNames to elements to make them more specific Fixes bug where an error would be triggered when the initialDates attribute was not set. Also resets the minLimit to the passed one when provided via attributes or to null when none is available Hides the nav button when not enabled Changes the _default.yaml to have decent colors for the rendering :P Adds the function leftPad() to the helpers to do left padding of the months and days Improves the code based on the reviews' feedback. Also makes it more testable and fixes some bugs detected when developing the unit tests Converts the DaysPanel to a stateless component with no mods (for now) Improves the code based on reviews' feedback. Also makes it more testable and introduces a new method to merge the locale definitions Removes the enzyme-to-json package and brings jest-serializdr-enzyme which is then configured in the jest config Reverts the removal to give time to migrate the other unit tests. Adds the serializer configuration to the jest.config.json Adds the unit tests and its snapshots Updates the tests for UTC Removes the mods and the dataAttrs from the 'defaultProps'. Updates the snapshots Attempt to set some colors matching the defined color pattern Updates the snapshots Adds some aria-labels to increase accessibility Adds updated snapshots Fixes a lint error :P Adds a function to normalize the dates on the time Changes the code to use the newly added function Updates the tests to use the normalizeDate() and updates the snapshots Moves the 'bind' to its own declaration, to prevent warnings from linting Changed the 'extraClasses' variable to be named 'mods' Changes the 'npm test' to set the testing to be always UTC (to solve CI issues) Also added the TZ=utc to the update-snapshots script Adds a function processProps() to be used by both the constructor and the componentWillReceiveProps() from the Calendar component Adds a wrapper component to make the test of the props being changed. Also adds a test to verify the componentWillReceiveProps. Updates the snapshots Improves coverage of the componentWillReceiveProps Downgraded eslint-plugin-react due to a bug on the jsx-indent rule: jsx-eslint/eslint-plugin-react#1117 Fixes the issue with the eslint-plugin-react's version, enabling the indentLogicalExpressions Adds the possibility to override the display text in the navigation buttons, as well as the aria-label attribute * Adds the examples with a normal calendar with all props set and a range calendar with all props set * Fixes issue where renderDate was not between the min and max limits, so needed to be readjusted * Fixes issue where in the edge-months (0 and 11) we were doing improper math :D * Updates the snapshots and the tests to cover properly with the new changes * Fixes poor configuration on the .eslintrc * Improved readability on the ternary operator of the handling of the renderDate
* Changes the builder to use the util.inspect() to output the error Adds the Calendar component Updates the example to show the dates (not final) Changes the DaysPanel to export directly the class Makes the code more explicit on the calendar.js Makes the styles customizable Fixes the _default.yaml to be able to build Fixes SCSS to build :D Changes the builder to actually output (and colorize) when an error happens Adds classNames to elements to make them more specific Fixes bug where an error would be triggered when the initialDates attribute was not set. Also resets the minLimit to the passed one when provided via attributes or to null when none is available Hides the nav button when not enabled Changes the _default.yaml to have decent colors for the rendering :P Adds the function leftPad() to the helpers to do left padding of the months and days Improves the code based on the reviews' feedback. Also makes it more testable and fixes some bugs detected when developing the unit tests Converts the DaysPanel to a stateless component with no mods (for now) Improves the code based on reviews' feedback. Also makes it more testable and introduces a new method to merge the locale definitions Removes the enzyme-to-json package and brings jest-serializdr-enzyme which is then configured in the jest config Reverts the removal to give time to migrate the other unit tests. Adds the serializer configuration to the jest.config.json Adds the unit tests and its snapshots Updates the tests for UTC Removes the mods and the dataAttrs from the 'defaultProps'. Updates the snapshots Attempt to set some colors matching the defined color pattern Updates the snapshots Adds some aria-labels to increase accessibility Adds updated snapshots Fixes a lint error :P Adds a function to normalize the dates on the time Changes the code to use the newly added function Updates the tests to use the normalizeDate() and updates the snapshots Moves the 'bind' to its own declaration, to prevent warnings from linting Changed the 'extraClasses' variable to be named 'mods' Changes the 'npm test' to set the testing to be always UTC (to solve CI issues) Also added the TZ=utc to the update-snapshots script Adds a function processProps() to be used by both the constructor and the componentWillReceiveProps() from the Calendar component Adds a wrapper component to make the test of the props being changed. Also adds a test to verify the componentWillReceiveProps. Updates the snapshots Improves coverage of the componentWillReceiveProps Downgraded eslint-plugin-react due to a bug on the jsx-indent rule: jsx-eslint/eslint-plugin-react#1117 Fixes the issue with the eslint-plugin-react's version, enabling the indentLogicalExpressions Adds the possibility to override the display text in the navigation buttons, as well as the aria-label attribute * Adds the examples with a normal calendar with all props set and a range calendar with all props set * Fixes issue where renderDate was not between the min and max limits, so needed to be readjusted * Fixes issue where in the edge-months (0 and 11) we were doing improper math :D * Updates the snapshots and the tests to cover properly with the new changes * Fixes poor configuration on the .eslintrc * Improved readability on the ternary operator of the handling of the renderDate
Closes #383. Related to jsx-eslint/eslint-plugin-react#1117.
Closes #383. Related to jsx-eslint/eslint-plugin-react#1117.
# [1.1.0](v1.0.1...v1.1.0) (2024-03-16) ### chore * **deps-dev:** bump [@types](https://github.com/types)/node from 20.11.27 to 20.11.28 ([#13](#13)) ([738e28c](738e28c)) * **deps:** bump eslint-plugin-react from 7.34.0 to 7.34.1 ([#12](#12)) ([ad9f1b3](ad9f1b3)), closes [#3700](https://github.com/capitnflam/eslint-plugin/issues/3700) [#3701](https://github.com/capitnflam/eslint-plugin/issues/3701) [#3704](https://github.com/capitnflam/eslint-plugin/issues/3704) [#3705](https://github.com/capitnflam/eslint-plugin/issues/3705) [#3707](https://github.com/capitnflam/eslint-plugin/issues/3707) [#3713](https://github.com/capitnflam/eslint-plugin/issues/3713) [#3715](https://github.com/capitnflam/eslint-plugin/issues/3715) [#1000](https://github.com/capitnflam/eslint-plugin/issues/1000) [jsx-eslint/eslint-plugin-react#1000](jsx-eslint/eslint-plugin-react#1000) [#1002](https://github.com/capitnflam/eslint-plugin/issues/1002) [jsx-eslint/eslint-plugin-react#1002](jsx-eslint/eslint-plugin-react#1002) [#1005](https://github.com/capitnflam/eslint-plugin/issues/1005) [jsx-eslint/eslint-plugin-react#1005](jsx-eslint/eslint-plugin-react#1005) [#100](https://github.com/capitnflam/eslint-plugin/issues/100) [jsx-eslint/eslint-plugin-react#100](jsx-eslint/eslint-plugin-react#100) [#1010](https://github.com/capitnflam/eslint-plugin/issues/1010) [jsx-eslint/eslint-plugin-react#1010](jsx-eslint/eslint-plugin-react#1010) [#1013](https://github.com/capitnflam/eslint-plugin/issues/1013) [jsx-eslint/eslint-plugin-react#1013](jsx-eslint/eslint-plugin-react#1013) [#1022](https://github.com/capitnflam/eslint-plugin/issues/1022) [jsx-eslint/eslint-plugin-react#1022](jsx-eslint/eslint-plugin-react#1022) [#1029](https://github.com/capitnflam/eslint-plugin/issues/1029) [jsx-eslint/eslint-plugin-react#1029](jsx-eslint/eslint-plugin-react#1029) [#102](https://github.com/capitnflam/eslint-plugin/issues/102) [jsx-eslint/eslint-plugin-react#102](jsx-eslint/eslint-plugin-react#102) [#1034](https://github.com/capitnflam/eslint-plugin/issues/1034) [jsx-eslint/eslint-plugin-react#1034](jsx-eslint/eslint-plugin-react#1034) [#1038](https://github.com/capitnflam/eslint-plugin/issues/1038) [jsx-eslint/eslint-plugin-react#1038](jsx-eslint/eslint-plugin-react#1038) [#1041](https://github.com/capitnflam/eslint-plugin/issues/1041) [jsx-eslint/eslint-plugin-react#1041](jsx-eslint/eslint-plugin-react#1041) [#1043](https://github.com/capitnflam/eslint-plugin/issues/1043) [jsx-eslint/eslint-plugin-react#1043](jsx-eslint/eslint-plugin-react#1043) [#1046](https://github.com/capitnflam/eslint-plugin/issues/1046) [jsx-eslint/eslint-plugin-react#1046](jsx-eslint/eslint-plugin-react#1046) [#1047](https://github.com/capitnflam/eslint-plugin/issues/1047) [jsx-eslint/eslint-plugin-react#1047](jsx-eslint/eslint-plugin-react#1047) [#1050](https://github.com/capitnflam/eslint-plugin/issues/1050) [jsx-eslint/eslint-plugin-react#1050](jsx-eslint/eslint-plugin-react#1050) [#1053](https://github.com/capitnflam/eslint-plugin/issues/1053) [jsx-eslint/eslint-plugin-react#1053](jsx-eslint/eslint-plugin-react#1053) [#1057](https://github.com/capitnflam/eslint-plugin/issues/1057) [jsx-eslint/eslint-plugin-react#1057](jsx-eslint/eslint-plugin-react#1057) [#105](https://github.com/capitnflam/eslint-plugin/issues/105) [jsx-eslint/eslint-plugin-react#105](jsx-eslint/eslint-plugin-react#105) [#1061](https://github.com/capitnflam/eslint-plugin/issues/1061) [jsx-eslint/eslint-plugin-react#1061](jsx-eslint/eslint-plugin-react#1061) [#1062](https://github.com/capitnflam/eslint-plugin/issues/1062) [jsx-eslint/eslint-plugin-react#1062](jsx-eslint/eslint-plugin-react#1062) [#1070](https://github.com/capitnflam/eslint-plugin/issues/1070) [jsx-eslint/eslint-plugin-react#1070](jsx-eslint/eslint-plugin-react#1070) [#1071](https://github.com/capitnflam/eslint-plugin/issues/1071) [jsx-eslint/eslint-plugin-react#1071](jsx-eslint/eslint-plugin-react#1071) [#1073](https://github.com/capitnflam/eslint-plugin/issues/1073) [jsx-eslint/eslint-plugin-react#1073](jsx-eslint/eslint-plugin-react#1073) [#1076](https://github.com/capitnflam/eslint-plugin/issues/1076) [jsx-eslint/eslint-plugin-react#1076](jsx-eslint/eslint-plugin-react#1076) [#1079](https://github.com/capitnflam/eslint-plugin/issues/1079) [jsx-eslint/eslint-plugin-react#1079](jsx-eslint/eslint-plugin-react#1079) [#1088](https://github.com/capitnflam/eslint-plugin/issues/1088) [jsx-eslint/eslint-plugin-react#1088](jsx-eslint/eslint-plugin-react#1088) [#1098](https://github.com/capitnflam/eslint-plugin/issues/1098) [jsx-eslint/eslint-plugin-react#1098](jsx-eslint/eslint-plugin-react#1098) [#1101](https://github.com/capitnflam/eslint-plugin/issues/1101) [jsx-eslint/eslint-plugin-react#1101](jsx-eslint/eslint-plugin-react#1101) [#1103](https://github.com/capitnflam/eslint-plugin/issues/1103) [jsx-eslint/eslint-plugin-react#1103](jsx-eslint/eslint-plugin-react#1103) [#110](https://github.com/capitnflam/eslint-plugin/issues/110) [jsx-eslint/eslint-plugin-react#110](jsx-eslint/eslint-plugin-react#110) [#1116](https://github.com/capitnflam/eslint-plugin/issues/1116) [jsx-eslint/eslint-plugin-react#1116](jsx-eslint/eslint-plugin-react#1116) [#1117](https://github.com/capitnflam/eslint-plugin/issues/1117) [jsx-eslint/eslint-plugin-react#1117](jsx-eslint/eslint-plugin-react#1117) [#1119](https://github.com/capitnflam/eslint-plugin/issues/1119) [jsx-eslint/eslint-plugin-react#1119](jsx-eslint/eslint-plugin-react#1119) [#1121](https://github.com/capitnflam/eslint-plugin/issues/1121) [jsx-eslint/eslint-plugin-react#1121](jsx-eslint/eslint-plugin-react#1121) [#1122](https://github.com/capitnflam/eslint-plugin/issues/1122) [jsx-eslint/eslint-plugin-react#1122](jsx-eslint/eslint-plugin-react#1122) [#1123](https://github.com/capitnflam/eslint-plugin/issues/1123) [jsx-eslint/eslint-plugin-react#1123](jsx-eslint/eslint-plugin-react#1123) [#3700](https://github.com/capitnflam/eslint-plugin/issues/3700) [#3701](https://github.com/capitnflam/eslint-plugin/issues/3701) [#3704](https://github.com/capitnflam/eslint-plugin/issues/3704) [#3705](https://github.com/capitnflam/eslint-plugin/issues/3705) [#3707](https://github.com/capitnflam/eslint-plugin/issues/3707) [#3713](https://github.com/capitnflam/eslint-plugin/issues/3713) [#3715](https://github.com/capitnflam/eslint-plugin/issues/3715) [#3715](https://github.com/capitnflam/eslint-plugin/issues/3715) [jsx-eslint/eslint-plugin-react#3715](jsx-eslint/eslint-plugin-react#3715) [#3713](https://github.com/capitnflam/eslint-plugin/issues/3713) [jsx-eslint/eslint-plugin-react#3713](jsx-eslint/eslint-plugin-react#3713) [#3707](https://github.com/capitnflam/eslint-plugin/issues/3707) [jsx-eslint/eslint-plugin-react#3707](jsx-eslint/eslint-plugin-react#3707) [#3705](https://github.com/capitnflam/eslint-plugin/issues/3705) [jsx-eslint/eslint-plugin-react#3705](jsx-eslint/eslint-plugin-react#3705) [#3704](https://github.com/capitnflam/eslint-plugin/issues/3704) [jsx-eslint/eslint-plugin-react#3704](jsx-eslint/eslint-plugin-react#3704) [#3701](https://github.com/capitnflam/eslint-plugin/issues/3701) [jsx-eslint/eslint-plugin-react#3701](jsx-eslint/eslint-plugin-react#3701) [#3700](https://github.com/capitnflam/eslint-plugin/issues/3700) [jsx-eslint/eslint-plugin-react#3700](jsx-eslint/eslint-plugin-react#3700) ### ci * add auto assign action ([#14](#14)) ([07d1f9a](07d1f9a)) * add check workflow ([#11](#11)) ([8afc82a](8afc82a)) ### feat * add [@eslint-community](https://github.com/eslint-community)/eslint-plugin-eslint-comments ([#17](#17)) ([fe2bf30](fe2bf30)) * add eslint-plugin-n ([#18](#18)) ([203d603](203d603)) * add eslint-plugin-security ([#16](#16)) ([e7f8c2e](e7f8c2e)) * add eslint-plugin-sonarjs ([#15](#15)) ([5bca4e1](5bca4e1)) * **react:** add some security linting ([#10](#10)) ([4424b67](4424b67))
Error:
Code from
103:11
:https://github.com/diegohaz/arc/blob/84ef1227b18f3d80ac6a297345ccc007ab191015/src/components/molecules/Modal/index.js#L103
On
v6.10.0
it doesn't occur.The text was updated successfully, but these errors were encountered: