Skip to content

Commit 74d5dec

Browse files
michaelfaithljharb
authored andcommittedJul 18, 2024
[Tests] remove duplicate tests
1 parent 05a5e49 commit 74d5dec

5 files changed

+4
-38
lines changed
 

‎__tests__/src/rules/anchor-is-valid-test.js

+3-28
Original file line numberDiff line numberDiff line change
@@ -272,14 +272,9 @@ ruleTester.run('anchor-is-valid', rule, {
272272
options: noHrefAspect,
273273
},
274274

275-
// CUSTOM COMPONENTS AND SPECIALLINK AND ASPECT
275+
// CUSTOM COMPONENTS AND SPECIAL LINK AND ASPECT
276276
{ code: '<Anchor hrefLeft={undefined} />', options: componentsAndSpecialLinkAndInvalidHrefAspect },
277277
{ code: '<Anchor hrefLeft={null} />', options: componentsAndSpecialLinkAndInvalidHrefAspect },
278-
{ code: '<Anchor hrefLeft={undefined} />', options: componentsAndSpecialLinkAndInvalidHrefAspect },
279-
{ code: '<Anchor hrefLeft={null} />', options: componentsAndSpecialLinkAndInvalidHrefAspect },
280-
{ code: '<Anchor hrefLeft={undefined} />', options: componentsAndSpecialLinkAndInvalidHrefAspect },
281-
{ code: '<Anchor hrefLeft={null} />', options: componentsAndSpecialLinkAndInvalidHrefAspect },
282-
283278
)).map(parserOptionsMapper),
284279
invalid: parsers.all([].concat(
285280
// DEFAULT ELEMENT 'a' TESTS
@@ -372,7 +367,7 @@ ruleTester.run('anchor-is-valid', rule, {
372367
options: specialLink,
373368
},
374369

375-
// CUSTOM BOTH COMPONENTS AND SPECIALLINK TESTS
370+
// CUSTOM BOTH COMPONENTS AND SPECIAL LINK TESTS
376371
// NO HREF
377372
{ code: '<Anchor Anchor={undefined} />', errors: [noHrefexpectedError], options: componentsAndSpecialLink },
378373
{ code: '<Anchor hrefLeft={null} />', errors: [noHrefexpectedError], options: componentsAndSpecialLink },
@@ -522,27 +517,7 @@ ruleTester.run('anchor-is-valid', rule, {
522517
errors: [invalidHrefexpectedError],
523518
},
524519

525-
// CUSTOM COMPONENTS AND SPECIALLINK AND ASPECT
526-
{
527-
code: '<Anchor hrefLeft={undefined} />',
528-
options: componentsAndSpecialLinkAndNoHrefAspect,
529-
errors: [noHrefexpectedError],
530-
},
531-
{
532-
code: '<Anchor hrefLeft={null} />',
533-
options: componentsAndSpecialLinkAndNoHrefAspect,
534-
errors: [noHrefexpectedError],
535-
},
536-
{
537-
code: '<Anchor hrefLeft={undefined} />',
538-
options: componentsAndSpecialLinkAndNoHrefAspect,
539-
errors: [noHrefexpectedError],
540-
},
541-
{
542-
code: '<Anchor hrefLeft={null} />',
543-
options: componentsAndSpecialLinkAndNoHrefAspect,
544-
errors: [noHrefexpectedError],
545-
},
520+
// CUSTOM COMPONENTS AND SPECIAL LINK AND ASPECT
546521
{
547522
code: '<Anchor hrefLeft={undefined} />',
548523
options: componentsAndSpecialLinkAndNoHrefAspect,

‎__tests__/src/rules/no-noninteractive-element-interactions-test.js

-2
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,6 @@ const neverValid = [
336336
{ code: '<tfoot onClick={() => {}} />;', errors: [expectedError] },
337337
{ code: '<thead onClick={() => {}} />;', errors: [expectedError] },
338338
{ code: '<time onClick={() => {}} />;', errors: [expectedError] },
339-
{ code: '<ol onClick={() => {}} />;', errors: [expectedError] },
340339
{ code: '<ul onClick={() => {}} />;', errors: [expectedError] },
341340
{ code: '<ul contentEditable="false" onClick={() => {}} />;', errors: [expectedError] },
342341
{ code: '<article contentEditable onClick={() => {}} />;', errors: [expectedError] },
@@ -345,7 +344,6 @@ const neverValid = [
345344
{ code: '<div role="alert" onClick={() => {}} />;', errors: [expectedError] },
346345
{ code: '<div role="alertdialog" onClick={() => {}} />;', errors: [expectedError] },
347346
{ code: '<div role="application" onClick={() => {}} />;', errors: [expectedError] },
348-
{ code: '<div role="article" onClick={() => {}} />;', errors: [expectedError] },
349347
{ code: '<div role="banner" onClick={() => {}} />;', errors: [expectedError] },
350348
{ code: '<div role="cell" onClick={() => {}} />;', errors: [expectedError] },
351349
{ code: '<div role="complementary" onClick={() => {}} />;', errors: [expectedError] },

‎__tests__/src/rules/no-noninteractive-element-to-interactive-role-test.js

-2
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,6 @@ const neverValid = [
360360
* interactive role. */
361361
{ code: '<main role="button" />;', errors: [expectedError] },
362362
{ code: '<article role="button" />;', errors: [expectedError] },
363-
{ code: '<article role="button" />;', errors: [expectedError] },
364363
{ code: '<aside role="button" />;', errors: [expectedError] },
365364
{ code: '<blockquote role="button" />;', errors: [expectedError] },
366365
{ code: '<body role="button" />;', errors: [expectedError] },
@@ -412,7 +411,6 @@ const neverValid = [
412411
* interactive role. */
413412
{ code: '<main role="menuitem" />;', errors: [expectedError] },
414413
{ code: '<article role="menuitem" />;', errors: [expectedError] },
415-
{ code: '<article role="menuitem" />;', errors: [expectedError] },
416414
{ code: '<dd role="menuitem" />;', errors: [expectedError] },
417415
{ code: '<dfn role="menuitem" />;', errors: [expectedError] },
418416
{ code: '<dt role="menuitem" />;', errors: [expectedError] },

‎__tests__/src/rules/no-static-element-interactions-test.js

-1
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,6 @@ const neverValid = [
304304
{ code: '<content onClick={() => {}} />;', errors: [expectedError] },
305305
{ code: '<data onClick={() => {}} />;', errors: [expectedError] },
306306
{ code: '<del onClick={() => {}} />;', errors: [expectedError] },
307-
{ code: '<div onClick={() => {}} />;', errors: [expectedError] },
308307
{ code: '<em onClick={() => {}} />;', errors: [expectedError] },
309308
{ code: '<font onClick={() => {}} />;', errors: [expectedError] },
310309
{ code: '<frameset onClick={() => {}} />;', errors: [expectedError] },

‎__tests__/src/rules/prefer-tag-over-role-test.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const expectedError = (role, tag) => ({
1010
type: 'JSXOpeningElement',
1111
});
1212

13-
ruleTester.run('element-role', rule, {
13+
ruleTester.run('prefer-tag-over-role', rule, {
1414
valid: parsers.all([].concat(
1515
{ code: '<div />;' },
1616
{ code: '<div role="unknown" />;' },
@@ -55,10 +55,6 @@ ruleTester.run('element-role', rule, {
5555
code: '<other role="checkbox" />',
5656
errors: [expectedError('checkbox', '<input type="checkbox">')],
5757
},
58-
{
59-
code: '<other role="checkbox" />',
60-
errors: [expectedError('checkbox', '<input type="checkbox">')],
61-
},
6258
{
6359
code: '<div role="banner" />',
6460
errors: [expectedError('banner', '<header>')],

0 commit comments

Comments
 (0)
Please sign in to comment.