Allow parent resolve before describe.

[DaddyWarbucks]

Solves: #2050

This PR updates the object, array, and tuple schemas such that they are resolved before being described. This ensures that the describe method works for things like object({...}).when(...)

[SpiderDan98]

Thanks for the pretty quick fix

[jquense]

can we combine the two here, and just keep the one override?

[DaddyWarbucks]

Perhaps, but I struggled to understand how. I started off with something like

 describe(options?: ResolveOptions<TContext>) {
    const next = options ? this.resolve(options) : this.clone();
    let base = next.describe(options) as SchemaObjectDescription;
    ...
  }

But the problem is the .resolve() and .clone() both return a new schema. So that following next.describe() causes an infinite loop.

[DaddyWarbucks]

I could do this

 describe(options?: ResolveOptions<TContext>) {
    const next = options ? this.resolve(options) : this.clone();
    let base = Schema.prototype.describe.call(next, options)  as SchemaObjectDescription
    ...
  }

[DaddyWarbucks]

Another solution would be to remove this line:

yup/src/schema.ts

Line 908 in 1178437

const next = (options ? this.resolve(options) : this).clone();

And then add a describe method to every type that does the resolve/clone itself before calling super.describe(). This is explicit and seems OK too.

Which doe you prefer @jquense?

• Use describe and _describe as the code is now
• Use Schema.prototype.describe.call
• Define and explicit describe method on each type that is responsible for resolving itself

[jquense]

what about:

const next = this.resolve(options)
const base = this.withMutation(() => {
   return next.describe() // no options, shouldn't resolve
})

...

withMutation could be removed i am not sure why the root describe calls clone() maybe just to be safe with handing out mutable schema internals

[DaddyWarbucks]

I believe calling next.describe() would cause an infinite loop. I think I have a good solution, and I have updated the PR @jquense.
The code now resolves these types twice in the describe method. For example

const next = (options ? this.resolve(options) : this).clone();
const base = super.describe(options) as SchemaInnerTypeDescription;

Then we can use next.whatever instead of this.whatever to use the new resolved schema to add additional information to the description. I'm not really concerned about any performance overhead there. I don't think the describe method is generally being used in performance critical areas, and the clone and resolve should be fast anyway.

[jquense]

yeah this is nice straightforward, works for me

[lukefredrickson]

@DaddyWarbucks thanks for working on this — much appreciated!

[lukefredrickson]

@jquense @DaddyWarbucks Sorry to be a bother, but do you have an ETA for merging this work in?

[DaddyWarbucks]

Thats above my pay grade.