Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The annotations on our diagrams are inconsistent. #3362

Open
1 of 10 tasks
joshwooding opened this issue May 3, 2024 · 0 comments
Open
1 of 10 tasks

The annotations on our diagrams are inconsistent. #3362

joshwooding opened this issue May 3, 2024 · 0 comments
Labels
priority: low 😴 type: bug 🪲 Something isn't working

Comments

@joshwooding
Copy link
Contributor

joshwooding commented May 3, 2024 •
edited by yunjungyeh

Package name(s)

Website / Documentation

Package version(s)

No response

Description

Some annotations include colons after a type e.g. Component: some don't

image
https://www.saltdesignsystem.com/salt/patterns/app-header#desktop-layout

vs

image
https://www.saltdesignsystem.com/salt/patterns/button-bar#layout

Some stack layout annotations, call them a component other's don't

image
https://www.saltdesignsystem.com/salt/patterns/button-bar#layout

vs

image
https://www.saltdesignsystem.com/salt/patterns/selectable-card#card-layout

same type labels are label small, other's aren't.

image
https://www.saltdesignsystem.com/salt/patterns/app-header#desktop-layout

vs

image
https://www.saltdesignsystem.com/salt/patterns/button-bar#layout

Steps to reproduce

No response

Expected behavior

No response

Operating system

  • macOS
  • Windows
  • Linux
  • iOS
  • Android

Browser

  • Chrome
  • Safari
  • Firefox
  • Edge

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@joshwooding joshwooding added type: bug 🪲 Something isn't working status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. priority: low 😴 and removed status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low 😴 type: bug 🪲 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshwooding