Energy prefixes #3019
Merged
Energy prefixes #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Carl! |
|
Published now in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the available prefixes for two units of energy in the library:
erg had no prefixes available but we find examples of kiloerg, Merg, and others in the wild like here and here. Adding SHORTLONG prefixes is consistent with the existing unit of bar.
joule was set to use SHORTLONG but the short prefixes are not common for this unit. Limiting it to only LONG prefixes is consistent with the existing unit of newton.
Thanks for your consideration!
Carl