Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showErrorTable is missing in JSONEditor.VALID_OPTIONS #1515

Closed
Mandy-Lf opened this issue May 12, 2023 · 3 comments
Closed

showErrorTable is missing in JSONEditor.VALID_OPTIONS #1515

Mandy-Lf opened this issue May 12, 2023 · 3 comments
Labels

Comments

@Mandy-Lf
Copy link

Since jsoneditor supports the new option showErrorTable now, this option is missing in JSONEditor.VALID_OPTIONS. Now a warning is logged in console when this option is used, 'Unknown option "showErrorTable". This option will be ignored'

@josdejong
Copy link
Owner

Thanks for reporting. Fixed now in v9.10.1

@josdejong josdejong added the bug label May 12, 2023
@Mandy-Lf
Copy link
Author

Mandy-Lf commented May 15, 2023

Really appreciated for the quick fix. Now showErrorTable was appended to VALID_OPTIONS. It should be showErrorTable without trailing spaces

@josdejong
Copy link
Owner

Ouch, thanks for reporting back. This is one of these cases where I thought like "this one-line fix is so obvious that I don't have to test it" that's proven wrong 😳.

I've fixed it and tested the feature, and whilst testing noticed that the original implementation had two bugs: it didn't work for showErrorTable: false, and it didn't work in preview mode. All fixed now in v9.10.2.

So, reminder to my future self: don't think you're smart, just test even the simplest fix 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants