Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease minimum serde version to 1.0.152 #653

Merged
merged 1 commit into from Oct 14, 2023
Merged

Conversation

banool
Copy link
Contributor

@banool banool commented Oct 9, 2023

As far as I can tell, the minimum version of 1.0.157 is unnecessary. The way I've determined that is just from running the build + tests:

cargo build --workspace
cargo test --workspace

This addresses #651. For my needs at least 1.0.152 is actually sufficient (rather than 1.0.149), though we could try go lower.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #653 (81507a2) into master (04bf8f3) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #653   +/-   ##
=======================================
  Coverage   64.85%   64.85%           
=======================================
  Files          36       36           
  Lines        2177     2177           
=======================================
  Hits         1412     1412           
  Misses        765      765           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonasbb
Copy link
Owner

jonasbb commented Oct 14, 2023

Loosening the version constraint looks fine, as long as the test still pass. Thanks for the PR.
bors r+

@bors
Copy link
Contributor

bors bot commented Oct 14, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit f55d41d into jonasbb:master Oct 14, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants