New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jQuery UI upgrade to 1.12 #105
Conversation
Actually it depends on actionpack 5.0, which is dependent on Rack 2.0, which is not compatible with ruby 1.9.3, and it causes all recent builds to fail
Please merge this :-) |
+1 |
2 similar comments
+1 |
+1 |
Thanks for the PR! Some comments:
diff --git a/jquery-ui-rails.gemspec b/jquery-ui-rails.gemspec
index 4ba6e19..43d58e9 100644
--- a/jquery-ui-rails.gemspec
+++ b/jquery-ui-rails.gemspec
@@ -15,7 +15,7 @@ Gem::Specification.new do |s|
s.add_dependency "railties", ">= 3.2.16"
- s.add_development_dependency "json", "~> 1.7"
+ s.add_development_dependency "json", "~> 2.0.2"
s.files = `git ls-files`.split("\n").reject { |f| f =~ /^testapp|^jquery-ui/ }
s.executables = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
|
|
//= require jquery-ui/tabs | ||
//= require jquery-ui/tooltip | ||
//= require jquery-ui/widget | ||
//= require jquery-ui/core.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there should be a trailing .js
here, should there?
@joliss thanks for review! |
Great, thanks! I've released v6.0.0 of this gem. |
Since directory structure has changed in 1.12, previous build system didn't work for 1.12.
jQuery UI doesn't have build info files, so there's no optimal way to get dependency list for each file. I ended up with parsing
define([...deps], factory)
block of each JS file.As a result:
ui
subfolder has been dropped for usage simplicity)I've also updated readme.md to follow new directory structure.
Please let me know any questions you have.
And it closes #103