Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The test autogeneration script seems to break the output files #236

Closed
TheoD02 opened this issue Jan 11, 2024 · 2 comments
Closed

The test autogeneration script seems to break the output files #236

TheoD02 opened this issue Jan 11, 2024 · 2 comments

Comments

@TheoD02
Copy link
Contributor

TheoD02 commented Jan 11, 2024

The test autogeneration script seems to break the output files, or at least change the output format, is this normal?

image

The problem is only present after the update to 6.4.*. "update to symfony 6.4.*" commit 0666110

EDIT :

The problem is present here too : https://github.com/jolicode/castor/pull/235/files#diff-fc5f4f1650c6b6065733fe148d65106f2953ba440c80b9cc33c03d7c4038421a

I have identified the package : symfony/console, version 6.4.1 work fine like before

The problem come from this change symfony/symfony#52940

You can fix this by removing the no-ansi option in bin/generate-tests.php but that will add the option to all existing tests so I'll let you decide how you want it to go but that was my investigation if it can helps 😄

@lyrixx
Copy link
Member

lyrixx commented Jan 12, 2024

see #237

@lyrixx
Copy link
Member

lyrixx commented Jan 12, 2024

can you rebase and tell me if it's okay now? if it's okay, you can close the issue. thanks

@TheoD02 TheoD02 closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants