Drop dateutil dependency #2173
Merged
Drop dateutil dependency #2173
+23
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need rebasing after #2172 is merged. |
fcurella
requested changes
Feb 10, 2025
Comment on lines
2342
to
2345
| if this_month_start.month == 12: | ||
| next_month_start = this_month_start.replace(year=this_month_start.year + 1, month=1) | ||
| else: | ||
| next_month_start = this_month_start.replace(month=this_month_start.month + 1) |
There was a problem hiding this comment.
I think we should abstract this logic into a function that can be reused
There was a problem hiding this comment.
Yep, was thinking about this as well, will have a look.
There was a problem hiding this comment.
I've done this (possibly could have done more, but would be rather substantial and possibly illegible so I stopped myself).
I also removed install_requires since it's now empty after this change and the Py38 removal.
|
It is still listed as a dependency after v36.0.0 release: I'm not really sure why... |
|
Sorry, my mistake. It's been removed in v36.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Removes dateutil.
What was wrong
Nothing really. Dateutil is a bit less maintained and the use of it here can be done fairly easily with the standard library.
How this fixes it
Fixes #2168
Replaced usage of dateutil with stlib stuff. Changes should be covered by existing tests. Had to change one test that was referencing dateutil directly.
Could maybe argue this is backwards-incompatible if people are doing
isinstancechecks or otherwise doing something weird, but maybe that is going a bit far.Checklist
make lint